Bug 71029 - Ask CG to not parse image metadata
Summary: Ask CG to not parse image metadata
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-27 10:05 PDT by Pratik Solanki
Modified: 2011-10-27 16:25 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.48 KB, patch)
2011-10-27 10:54 PDT, Pratik Solanki 		no flags Details | Formatted Diff | Diff
Patch (7.26 KB, patch)
2011-10-27 15:46 PDT, Pratik Solanki 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2011-10-27 10:05:11 PDT 
WebCore doesn't need any image metadata information from CG. We can request CG to not parse those and get a performance win.
Comment 1 Pratik Solanki 2011-10-27 10:54:46 PDT 
Created attachment 112707 [details]
Patch
Comment 2 Simon Fraser (smfr) 2011-10-27 10:59:23 PDT 
Comment on attachment 112707 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112707&action=review

> Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp:116
> +static CFDictionaryRef imageSourceOptions(ShouldSkipMetaData skip)

skip -> skipMetaData
Comment 3 Pratik Solanki 2011-10-27 15:46:22 PDT 
Created attachment 112772 [details]
Patch
Comment 4 Pratik Solanki 2011-10-27 16:25:27 PDT 
Committed r98657: <http://trac.webkit.org/changeset/98657>