Bug 71026 - Tighten font change conditions in matched declaration cache
Summary: Tighten font change conditions in matched declaration cache
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
Depends on: 71186
  Show dependency treegraph
Reported: 2011-10-27 09:28 PDT by Antti Koivisto
Modified: 2011-12-21 14:34 PST (History)
5 users (show)

See Also:

patch (4.19 KB, patch)
2011-10-27 09:37 PDT, Antti Koivisto
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2011-10-27 09:28:23 PDT
We currently test if font description has changed to see if all properties need to be applied. However only a few size related metrics can actually affect other properties. We can just test those, making the cache somewhat more effective while also making the test faster.
Comment 1 Antti Koivisto 2011-10-27 09:37:53 PDT
Created attachment 112694 [details]
Comment 2 Antti Koivisto 2011-10-29 02:36:41 PDT
Comment 3 Csaba Osztrogonác 2011-10-29 10:37:58 PDT
It made all tests assert on Qt in debug mode:

ASSERTION FAILED: fontCache()->generation() == m_generation
../../../Source/WebCore/platform/graphics/FontFallbackList.cpp(104) : const WebCore::FontData* WebCore::FontFallbackList::fontDataAt(const WebCore::Font*, unsigned int) const

Could you check it, please?
Comment 4 Ryosuke Niwa 2011-10-29 14:18:33 PDT
It appears that this patch broke 500+ tests on Windows:
Comment 5 Antti Koivisto 2011-10-30 09:06:12 PDT
Rolled out in http://trac.webkit.org/changeset/98826, don't know yet why this would fail only on some platforms.
Comment 6 Eric Seidel 2011-12-21 14:34:33 PST
Attachment 112694 [details] was posted by a committer and has review+, assigning to Antti Koivisto for commit.