Bug 71026 - Tighten font change conditions in matched declaration cache
: Tighten font change conditions in matched declaration cache
Status: REOPENED
: WebKit
CSS
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
: 71186
:
  Show dependency treegraph
 
Reported: 2011-10-27 09:28 PST by
Modified: 2011-12-21 14:34 PST (History)


Attachments
patch (4.19 KB, patch)
2011-10-27 09:37 PST, Antti Koivisto
darin: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-10-27 09:28:23 PST
We currently test if font description has changed to see if all properties need to be applied. However only a few size related metrics can actually affect other properties. We can just test those, making the cache somewhat more effective while also making the test faster.
------- Comment #1 From 2011-10-27 09:37:53 PST -------
Created an attachment (id=112694) [details]
patch
------- Comment #2 From 2011-10-29 02:36:41 PST -------
http://trac.webkit.org/changeset/98803
------- Comment #3 From 2011-10-29 10:37:58 PST -------
It made all tests assert on Qt in debug mode:

ASSERTION FAILED: fontCache()->generation() == m_generation
../../../Source/WebCore/platform/graphics/FontFallbackList.cpp(104) : const WebCore::FontData* WebCore::FontFallbackList::fontDataAt(const WebCore::Font*, unsigned int) const

Could you check it, please?
------- Comment #4 From 2011-10-29 14:18:33 PST -------
It appears that this patch broke 500+ tests on Windows:
http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/17418
------- Comment #5 From 2011-10-30 09:06:12 PST -------
Rolled out in http://trac.webkit.org/changeset/98826, don't know yet why this would fail only on some platforms.
------- Comment #6 From 2011-12-21 14:34:33 PST -------
Attachment 112694 [details] was posted by a committer and has review+, assigning to Antti Koivisto for commit.