If NO_LISTBOX_RENDERING is enabled RenderMenuList::listBoxSelectItem uses the HTMLSelectElement::listBoxSelectItem function which was accidentally removed in r97533. Reintroduce HTMLSelectElement::listBoxSelectItem with a NO_LISTBOX_RENDERING guard to unbreak this setup. This code path seems to be only used by Chromium and Qt: ./Source/WebKit/chromium/src/ExternalPopupMenu.cpp:136: listPopupMenuClient->listBoxSelectItem(indices[i], (i > 0), false, (i == indices.size() - 1)); ./Source/WebKit/qt/WebCoreSupport/PopupMenuQt.cpp:148: client->listBoxSelectItem(index, ctrl, shift);
Created attachment 112667 [details] proposed patch
Comment on attachment 112667 [details] proposed patch On so this wasn't really unused. It is used by RenderMenu::listBoxSelectItem which is used for NO_LISTBOX_RENDERING. Given that, r=me
Comment on attachment 112667 [details] proposed patch Clearing flags on attachment: 112667 Committed r98557: <http://trac.webkit.org/changeset/98557>
All reviewed patches have been landed. Closing bug.