Bug 71009 - Fix the build if NO_LISTBOX_RENDERING is enabled
Summary: Fix the build if NO_LISTBOX_RENDERING is enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andras Becsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-27 05:40 PDT by Andras Becsi
Modified: 2011-10-27 06:02 PDT (History)
4 users (show)

See Also:

Attachments
proposed patch (2.49 KB, patch)
2011-10-27 05:42 PDT, Andras Becsi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Becsi 2011-10-27 05:40:06 PDT 
If NO_LISTBOX_RENDERING is enabled RenderMenuList::listBoxSelectItem uses the HTMLSelectElement::listBoxSelectItem function which was accidentally removed in r97533.
Reintroduce HTMLSelectElement::listBoxSelectItem with a NO_LISTBOX_RENDERING guard to unbreak this setup.

This code path seems to be only used by Chromium and Qt:

./Source/WebKit/chromium/src/ExternalPopupMenu.cpp:136:            listPopupMenuClient->listBoxSelectItem(indices[i], (i > 0), false, (i == indices.size() - 1));
./Source/WebKit/qt/WebCoreSupport/PopupMenuQt.cpp:148:        client->listBoxSelectItem(index, ctrl, shift);
Comment 1 Andras Becsi 2011-10-27 05:42:44 PDT 
Created attachment 112667 [details]
proposed patch
Comment 2 Kenneth Rohde Christiansen 2011-10-27 05:58:09 PDT 
Comment on attachment 112667 [details]
proposed patch

On so this wasn't really unused. It is used by RenderMenu::listBoxSelectItem which is used for NO_LISTBOX_RENDERING. Given that, r=me
Comment 3 Andras Becsi 2011-10-27 06:02:51 PDT 
Comment on attachment 112667 [details]
proposed patch

Clearing flags on attachment: 112667

Committed r98557: <http://trac.webkit.org/changeset/98557>
Comment 4 Andras Becsi 2011-10-27 06:02:59 PDT 
All reviewed patches have been landed.  Closing bug.