Bug 71007 - [Microdata] Support for itemid attribute.
Summary: [Microdata] Support for itemid attribute.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 68609
  Show dependency treegraph
 
Reported: 2011-10-27 05:18 PDT by Arko Saha
Modified: 2011-10-31 15:23 PDT (History)
8 users (show)

See Also:


Attachments
Patch (7.22 KB, patch)
2011-10-27 05:30 PDT, Arko Saha
rniwa: review+
Details | Formatted Diff | Diff
Updated patch (7.21 KB, patch)
2011-10-27 10:09 PDT, Arko Saha
rniwa: review+
Details | Formatted Diff | Diff
Updated patch (7.95 KB, patch)
2011-10-31 07:29 PDT, Arko Saha
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arko Saha 2011-10-27 05:18:11 PDT
1. Support for itemid attribute. 
The itemid attribute specified, to give a global identifier for the Microdata item, so that it can be related to other items on pages elsewhere on the Web. The itemid attribute, if specified, must have a value that is a valid URL potentially surrounded by spaces.
Here is the spec : http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.html#attr-itemid

2. Add test-cases for itemid attribute.
Comment 1 Arko Saha 2011-10-27 05:30:11 PDT
Created attachment 112666 [details]
Patch
Comment 2 Ryosuke Niwa 2011-10-27 08:37:21 PDT
Comment on attachment 112666 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112666&action=review

> Source/WebCore/ChangeLog:8
> +        The itemid attribute specified, to give a global identifier for the Microdata item.

specified, to give?
Comment 3 Arko Saha 2011-10-27 10:09:49 PDT
Created attachment 112697 [details]
Updated patch
Comment 4 Arko Saha 2011-10-31 06:31:34 PDT
Hi Ryosuke, can you please review the patch? Thanks.
Comment 5 Ryosuke Niwa 2011-10-31 06:47:55 PDT
Comment on attachment 112697 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112697&action=review

> LayoutTests/fast/dom/MicroData/itemid-attribute-test-expected.txt:18
> +PASS createElement('div', {itemid: ' http://example.com/foo '}).itemId == 'http://example.com/foo'; is true

You should test leading whitespace as well.
Comment 6 Arko Saha 2011-10-31 07:29:15 PDT
Created attachment 113049 [details]
Updated patch

Incorporating review comments.
Comment 7 WebKit Review Bot 2011-10-31 15:23:05 PDT
Comment on attachment 113049 [details]
Updated patch

Clearing flags on attachment: 113049

Committed r98888: <http://trac.webkit.org/changeset/98888>
Comment 8 WebKit Review Bot 2011-10-31 15:23:11 PDT
All reviewed patches have been landed.  Closing bug.