Bug 70974 - IndexedDB: Database metadata changes should be tied to transaction
Summary: IndexedDB: Database metadata changes should be tied to transaction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-26 15:52 PDT by Joshua Bell
Modified: 2011-10-28 12:22 PDT (History)
4 users (show)

See Also:


Attachments
Patch (18.33 KB, patch)
2011-10-26 16:01 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff
Patch (18.52 KB, patch)
2011-10-28 11:26 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2011-10-26 15:52:44 PDT
IndexedDB: Database metadata changes should be tied to transaction
Comment 1 Joshua Bell 2011-10-26 16:01:56 PDT
Created attachment 112610 [details]
Patch
Comment 2 Joshua Bell 2011-10-26 17:18:45 PDT
Suggestions for additional tests welcome.
Comment 3 Joshua Bell 2011-10-27 16:31:15 PDT
Chromium test that verifies the fix added at: http://codereview.chromium.org/8341092
Comment 4 Hans Wennborg 2011-10-28 08:48:30 PDT
Looks good to me.
Comment 5 Joshua Bell 2011-10-28 10:21:18 PDT
Comment on attachment 112610 [details]
Patch

tony@, can you r/cq?
Comment 6 Tony Chang 2011-10-28 10:56:02 PDT
Comment on attachment 112610 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112610&action=review

> LayoutTests/storage/indexeddb/open-during-transaction.html:92
> +var successfullyParsed = true;

Nit: You don't need to add this anymore.

> LayoutTests/storage/indexeddb/version-change-abort.html:96
> +var successfullyParsed = true;

Ditto
Comment 7 Joshua Bell 2011-10-28 11:26:41 PDT
Created attachment 112883 [details]
Patch
Comment 8 Joshua Bell 2011-10-28 11:28:12 PDT
Comment on attachment 112883 [details]
Patch

thanks tony@ - it required slightly non-trivial tweak due to exception handling. One more try?
Comment 9 WebKit Review Bot 2011-10-28 12:22:42 PDT
Comment on attachment 112883 [details]
Patch

Clearing flags on attachment: 112883

Committed r98749: <http://trac.webkit.org/changeset/98749>
Comment 10 WebKit Review Bot 2011-10-28 12:22:46 PDT
All reviewed patches have been landed.  Closing bug.