RESOLVED FIXED 70968
De-virtualize isGlobalObject, isVariableObject, isActivationObject, and isErrorInstance in JSObject 
https://bugs.webkit.org/show_bug.cgi?id=70968
Summary De-virtualize isGlobalObject, isVariableObject, isActivationObject, and isErr...
Mark Hahnenberg
Reported 2011-10-26 14:24:05 PDT
These can all be de-virtualized by augmenting JSType with additional types.
Attachments
Patch (19.76 KB, patch)
2011-10-27 12:43 PDT, Mark Hahnenberg 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2011-10-27 12:43:04 PDT
Created attachment 112732 [details] Patch
Geoffrey Garen
Comment 2 2011-10-28 10:52:53 PDT
Comment on attachment 112732 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112732&action=review Seems like TypeInfo should eventually move to being specified in ClassInfo, even if a copy is cached in Structure. More elegant to specify TypeInfo declaratively, instead of through a bunch of function call arguments. > Source/JavaScriptCore/runtime/JSType.h:47 > + // VariableObjectType must be greater than all of the types of its subclasses. Less than!
Mark Hahnenberg
Comment 3 2011-10-28 12:15:03 PDT
Committed r98747: <http://trac.webkit.org/changeset/98747>
Note You need to log in before you can comment on or make changes to this bug.