RESOLVED FIXED 70965
[Qt][WK2] Move the C API callback setup out of QtWebPageProxy 
https://bugs.webkit.org/show_bug.cgi?id=70965
Summary [Qt][WK2] Move the C API callback setup out of QtWebPageProxy
Alexis Menard (darktears)
Reported 2011-10-26 13:43:14 PDT
[Qt][WK2] Move the setup C API callback out of QtWebPageProxy
Attachments
Patch (18.50 KB, patch)
2011-10-26 13:44 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Patch (18.65 KB, patch)
2011-10-26 13:57 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1 2011-10-26 13:44:35 PDT
Created attachment 112589 [details] Patch
Andreas Kling
Comment 2 2011-10-26 13:47:41 PDT
Comment on attachment 112589 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112589&action=review > Source/WebKit2/ChangeLog:3 > + [Qt][WK2] Move the setup C API callback out of QtWebPageProxy Move the C API callback setup out of QtWebPageProxy > Source/WebKit2/UIProcess/qt/ClientImpl.h:34 > #endif /* DefaultClientCallbacksQt_h */ Just noticed this name is wrong. > Source/WebKit2/UIProcess/qt/QtWebPageProxy.h:173 > + WebKit::QtViewInterface* viewInterface() const { return m_viewInterface; } Is the WebKit:: really needed here?
Alexis Menard (darktears)
Comment 3 2011-10-26 13:57:45 PDT
Created attachment 112591 [details] Patch
Andreas Kling
Comment 4 2011-10-26 13:58:43 PDT
Comment on attachment 112591 [details] Patch r=kenneth
WebKit Review Bot
Comment 5 2011-10-27 07:37:15 PDT
Comment on attachment 112591 [details] Patch Clearing flags on attachment: 112591 Committed r98570: <http://trac.webkit.org/changeset/98570>
WebKit Review Bot
Comment 6 2011-10-27 07:37:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.