Bug 70965 - [Qt][WK2] Move the C API callback setup out of QtWebPageProxy
Summary: [Qt][WK2] Move the C API callback setup out of QtWebPageProxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexis Menard (darktears)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-26 13:43 PDT by Alexis Menard (darktears)
Modified: 2011-10-27 07:37 PDT (History)
1 user (show)

See Also:


Attachments
Patch (18.50 KB, patch)
2011-10-26 13:44 PDT, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff
Patch (18.65 KB, patch)
2011-10-26 13:57 PDT, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2011-10-26 13:43:14 PDT
[Qt][WK2] Move the setup C API callback out of QtWebPageProxy
Comment 1 Alexis Menard (darktears) 2011-10-26 13:44:35 PDT
Created attachment 112589 [details]
Patch
Comment 2 Andreas Kling 2011-10-26 13:47:41 PDT
Comment on attachment 112589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112589&action=review

> Source/WebKit2/ChangeLog:3
> +        [Qt][WK2] Move the setup C API callback out of QtWebPageProxy

Move the C API callback setup out of QtWebPageProxy

> Source/WebKit2/UIProcess/qt/ClientImpl.h:34
>  #endif /* DefaultClientCallbacksQt_h */

Just noticed this name is wrong.

> Source/WebKit2/UIProcess/qt/QtWebPageProxy.h:173
> +    WebKit::QtViewInterface* viewInterface() const { return m_viewInterface; }

Is the WebKit:: really needed here?
Comment 3 Alexis Menard (darktears) 2011-10-26 13:57:45 PDT
Created attachment 112591 [details]
Patch
Comment 4 Andreas Kling 2011-10-26 13:58:43 PDT
Comment on attachment 112591 [details]
Patch

r=kenneth
Comment 5 WebKit Review Bot 2011-10-27 07:37:15 PDT
Comment on attachment 112591 [details]
Patch

Clearing flags on attachment: 112591

Committed r98570: <http://trac.webkit.org/changeset/98570>
Comment 6 WebKit Review Bot 2011-10-27 07:37:46 PDT
All reviewed patches have been landed.  Closing bug.