Bug 70959 - JS Test Harness: Remove js-test-post-function.js
Summary: JS Test Harness: Remove js-test-post-function.js
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on:
Blocks: 70944
  Show dependency tree / graph
 
Reported: 2011-10-26 13:06 PDT by Erik Arvidsson
Modified: 2011-11-01 10:35 PDT (History)
3 users (show)

See Also:

Attachments
Patch (126.56 KB, patch)
2011-10-26 14:55 PDT, Erik Arvidsson 		ojan: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2011-10-26 13:06:28 PDT 
js-test-post-function.js only contains the function isSuccessfullyParsed. By moving this to js-test-pre.js we can remove that file.
Comment 1 Erik Arvidsson 2011-10-26 14:55:28 PDT 
Created attachment 112602 [details]
Patch
Comment 2 Ojan Vafai 2011-10-26 15:11:55 PDT 
Comment on attachment 112602 [details]
Patch

If we wrap waitUntilDone/notifyDone we won't need this method at all, right? It seems to me people only use it to allow js-tests that use waitUntilDone (e.g. because they need a setTimeout). In either case, this patch is certainly a step in that direction.
Comment 3 Erik Arvidsson 2011-10-26 15:55:50 PDT 
(In reply to comment #2)
> If we wrap waitUntilDone/notifyDone we won't need this method at all, right?

Correct, this should go away eventually.
Comment 4 WebKit Review Bot 2011-10-27 07:38:13 PDT 
Comment on attachment 112602 [details]
Patch

Attachment 112602 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10227541

New failing tests:
storage/indexeddb/exception-in-event-aborts.html
Comment 5 Erik Arvidsson 2011-10-28 10:36:03 PDT 
Committed r98733: <http://trac.webkit.org/changeset/98733>
Comment 6 Kent Tamura 2011-10-31 18:44:46 PDT 
(In reply to comment #5)
> Committed r98733: <http://trac.webkit.org/changeset/98733>

It removed a lot of ChangeLog entries.
http://trac.webkit.org/changeset/98733/trunk/LayoutTests/ChangeLog
Comment 7 Erik Arvidsson 2011-10-31 18:51:38 PDT 
Ouch, do you want me to restore that?
Comment 8 Kent Tamura 2011-10-31 18:53:03 PDT 
Yes, please :-)
Comment 9 Erik Arvidsson 2011-11-01 10:35:21 PDT 
Restored in http://trac.webkit.org/changeset/98976