WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
70958
De-virtualize JSCell::toThisObject
https://bugs.webkit.org/show_bug.cgi?id=70958
Summary
De-virtualize JSCell::toThisObject
Mark Hahnenberg
Reported
2011-10-26 12:52:41 PDT
This should be the last virtual method (other than the destructor) in JSCell. I'm simply going to add it to the MethodTable. Since it is a relatively minor addition to the MethodTable compared to past additions, I'll just wrap all of the usual stages into a single patch.
Attachments
Patch
(24.50 KB, patch)
2011-10-26 14:20 PDT
,
Mark Hahnenberg
no flags
Details
Formatted Diff
Diff
Patch
(25.28 KB, patch)
2011-10-26 14:40 PDT
,
Mark Hahnenberg
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1
2011-10-26 14:20:26 PDT
Created
attachment 112592
[details]
Patch
Early Warning System Bot
Comment 2
2011-10-26 14:33:13 PDT
Comment on
attachment 112592
[details]
Patch
Attachment 112592
[details]
did not pass qt-ews (qt): Output:
http://queues.webkit.org/results/10211783
Mark Hahnenberg
Comment 3
2011-10-26 14:40:48 PDT
Created
attachment 112597
[details]
Patch
Geoffrey Garen
Comment 4
2011-10-26 15:34:41 PDT
Comment on
attachment 112597
[details]
Patch r=me
WebKit Review Bot
Comment 5
2011-10-27 10:01:55 PDT
Comment on
attachment 112597
[details]
Patch Clearing flags on attachment: 112597 Committed
r98593
: <
http://trac.webkit.org/changeset/98593
>
WebKit Review Bot
Comment 6
2011-10-27 10:01:59 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug