Bug 70952 - [Qt] Support the Web Open Font Format (WOFF)
Summary: [Qt] Support the Web Open Font Format (WOFF)
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-26 11:43 PDT by Helder Correia
Modified: 2014-02-03 03:19 PST (History)
6 users (show)

See Also:


Attachments
Patch (5.49 KB, patch)
2011-10-26 12:21 PDT, Helder Correia
eric: review-
Details | Formatted Diff | Diff
qtwebkit-2.3.2 fails to render some text of css3test.com (230.15 KB, image/png)
2013-08-27 05:23 PDT, Chen Zhixiang
no flags Details
Dump of css3test.com (14.24 KB, application/octet-stream)
2013-08-27 05:27 PDT, Chen Zhixiang
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Helder Correia 2011-10-26 11:43:03 PDT
Support for this format exists in platform/graphics/WOFFFileFormat*. (patch coming)
Comment 1 Helder Correia 2011-10-26 12:21:34 PDT
Created attachment 112577 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2011-10-26 15:22:51 PDT
Comment on attachment 112577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112577&action=review

> Source/WebCore/WebCore.pri:144
> +LIBS += -lz

So we are introducing another dependency... I guess it is alright, but can you check with Simon?
Comment 3 Simon Hausmann 2011-10-28 00:36:30 PDT
Comment on attachment 112577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112577&action=review

>> Source/WebCore/WebCore.pri:144

> 
> So we are introducing another dependency... I guess it is alright, but can you check with Simon?

This breaks the (native) build on Windows and technically it also requires changes on non-Windows to get the include path right. zlib.h isn't _guaranteed_ to be in /usr/include strictly speaking. If possible we should be using pkg-config then (and I guess on mac we can rely on fixed paths).

Options for Windows I can think of:

1) No support the feature there (urgh)
2) Pull in src/3rdparty/zlib.pri from the Qt sources (tricky)
3) In addition to 1 or 2, introduce the _option_ of building against a shared zlib on Windows with the ability to specify the include path and library path (or make take implicitly through INCLUDES/LIBS env)
Comment 4 Eric Seidel (no email) 2011-12-21 15:12:16 PST
Comment on attachment 112577 [details]
Patch

Simon's comments imply this should be r-.
Comment 5 Chen Zhixiang 2013-08-27 04:55:46 PDT
New regression level down occurred!

We have applied the patch a few month ago, and it goes well with html5test.com & css3test.com which both use WOFF web fonts.

But now, all sites suddenly broken down.

QtWebKit-2.3.2, which has contained this patch, built based upon Qt-4.8.x, also fails on css3test.com.

Since css3test.com uses web font files hosted on Google, i surpose that the font file formats have changed recently???
Comment 6 Chen Zhixiang 2013-08-27 05:04:04 PDT
css3test.com uses "text-shadow: 0 -.1em .2em black;", the newest Chrome 29.0.1547.57 m cannot display this text-shadow effect, while Firefox 23.0.1 can.
Comment 7 Chen Zhixiang 2013-08-27 05:23:46 PDT
Created attachment 209751 [details]
qtwebkit-2.3.2 fails to render some text of css3test.com
Comment 8 Chen Zhixiang 2013-08-27 05:27:15 PDT
Created attachment 209753 [details]
Dump of css3test.com

qtwebkit-2.3.2 config: -platform xlibgl -gl-viewport -graphicsbased -viewport-update-mode Full -no-compositing,

-platform xlib has no problem.
Comment 9 Jocelyn Turcotte 2014-02-03 03:19:11 PST
=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.