Bug 70936 - Web Inspector: [refactoring] TextPrompt: ensure encapsulation, extract history management
Summary: Web Inspector: [refactoring] TextPrompt: ensure encapsulation, extract histor...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-26 09:26 PDT by Alexander Pavlov (apavlov)
Modified: 2011-10-31 08:09 PDT (History)
10 users (show)

See Also:


Attachments
[PATCH] Suggested solution (41.32 KB, patch)
2011-10-28 07:28 PDT, Alexander Pavlov (apavlov)
pfeldman: review-
Details | Formatted Diff | Diff
[PATCH] Comments addressed (45.36 KB, patch)
2011-10-31 04:37 PDT, Alexander Pavlov (apavlov)
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2011-10-26 09:26:59 PDT
Patch to follow.
Comment 1 Alexander Pavlov (apavlov) 2011-10-28 07:28:51 PDT
Created attachment 112860 [details]
[PATCH] Suggested solution
Comment 2 Pavel Feldman 2011-10-31 02:07:49 PDT
Comment on attachment 112860 [details]
[PATCH] Suggested solution

View in context: https://bugs.webkit.org/attachment.cgi?id=112860&action=review

> Source/WebCore/inspector/front-end/TextPrompt.js:185
> +    _onKeyDown: function(event)

rename to onKeyDown and allow overriding for complex cases.

> Source/WebCore/inspector/front-end/TextPrompt.js:525
> +    this.commitOnTabWithSuggestion = false;

Could you please implement it using setCommitOn... on the TextPromptWithHistory?

> Source/WebCore/inspector/front-end/TextPrompt.js:531
> +    this.coalesceHistoryDups = true;

nit: Dupes?
Comment 3 Alexander Pavlov (apavlov) 2011-10-31 04:37:40 PDT
Created attachment 113039 [details]
[PATCH] Comments addressed
Comment 4 Alexander Pavlov (apavlov) 2011-10-31 08:09:27 PDT
Committed r98856: <http://trac.webkit.org/changeset/98856>