Bug 70911 – Access keys on non visible DOM elements can still be accessed

• Status: UNCONFIRMED
• Component: UI Events

[Iain Farrell]

Created attachment 112491 [details]
Showing unexpected access key behaviour

SVN revision: 97675

1. a webpage contains multiple elements with the same access key
2. all but one of these elements will be hidden
3. press the access key
4. the last on the page will always be selected, whether it is hidden or not.

It would be expected that the visible access key should be selected.

A simple test page is attached to show this.

[Alexey Proskuryakov]

> It would be expected that the visible access key should be selected.

Is this how it works in both IE and Firefox?

[Iain Farrell]

(In reply to comment #1)
> > It would be expected that the visible access key should be selected.
> 
> Is this how it works in both IE and Firefox?

Yes, it is - using the test page I attached, the pop up has the "visible div" text. In Safari and Chrome, it is "hidden div"

[Vineet Chaudhary (vineetc)]

Created attachment 116492 [details]
proposed patch

[Vineet Chaudhary (vineetc)]

Comment on attachment 116492 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116492&action=review

> Source/WebCore/dom/Document.cpp:652
> +        if (!accessKey.isEmpty() && ((element->renderStyle() && element->renderStyle()->display() != NONE) || element->hasTagName(areaTag) || element->hasTagName(mapTag)))

Added specific checks for area and map tag as both doesn't have renderer.

[Vineet Chaudhary (vineetc)]

Actually https://bugs.webkit.org/attachment.cgi?id=112491 this test case is only style display : none, but we should check visibility : hidden too as those are also not visible to user.

Please let me know your thoughts on this. I will upload the for the same.

[Alexey Proskuryakov]

Comment on attachment 116492 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116492&action=review

r- since this implements logic that's substantially different from Firefox. I did not test IE and did not check the spec - please feel free to re-nominate and explain why this is what we want.

> Source/WebCore/ChangeLog:8
> +        Access key should only work with visible(visually) elements.

This is incorrect. Access keys work just fine with display:none elements in Firefox.

The difference with WebKit is that Gecko does not immediately click an element with accesskey when there are multiple ones with the same assigned key. Firefox only focuses such elements, and it cycles over others as you repeatedly press the same access key combination.

[Alexey Proskuryakov]

Firefox behavior of course becomes weird when some of the elements are invisible - it cannot focus invisible ones, yet it behaves as if it could cycle over them.