Bug 70906 - Web Inspector: Execution line in selected call frame should keep showing after toggling format source.
Summary: Web Inspector: Execution line in selected call frame should keep showing afte...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-26 05:08 PDT by Vsevolod Vlasov
Modified: 2011-10-27 04:49 PDT (History)
11 users (show)

See Also:


Attachments
Patch (5.12 KB, patch)
2011-10-26 05:34 PDT, Vsevolod Vlasov
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2011-10-26 05:08:22 PDT
Execution line in selected call frame should keep showing after toggling format source.
Comment 1 Vsevolod Vlasov 2011-10-26 05:34:40 PDT
Created attachment 112485 [details]
Patch
Comment 2 Pavel Podivilov 2011-10-26 07:18:34 PDT
Comment on attachment 112485 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112485&action=review

> LayoutTests/inspector/debugger/selected-call-frame-after-formatting-source.html:50
> +<p>Tests execution line in selected call frame keeps showing after formatting source..</p>

I think it actually tests that selected call frame does not change when pretty-print is toggled.
Comment 3 Pavel Feldman 2011-10-26 08:33:38 PDT
Comment on attachment 112485 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112485&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:-315
> -        if (WebInspector.debuggerModel.callFrames)

So we are not rebuilding call frames now. Why?
Comment 4 Vsevolod Vlasov 2011-10-26 15:18:31 PDT
Comment on attachment 112485 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112485&action=review

>> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:-315
>> -        if (WebInspector.debuggerModel.callFrames)
> 
> So we are not rebuilding call frames now. Why?

They are already correctly updated based on events from rawSourceCodes.
Meanwhile calling debuggerPaused is bad because it resets selectedCallFrame to the top of the stack.
Comment 5 Yury Semikhatsky 2011-10-27 00:29:25 PDT
Comment on attachment 112485 [details]
Patch

Please update test description as Pavel suggests before landing.
Comment 6 Vsevolod Vlasov 2011-10-27 04:49:44 PDT
Committed r98549: <http://trac.webkit.org/changeset/98549>