RESOLVED FIXED 70906
Web Inspector: Execution line in selected call frame should keep showing after toggling format source. 
https://bugs.webkit.org/show_bug.cgi?id=70906
Summary Web Inspector: Execution line in selected call frame should keep showing afte...
Vsevolod Vlasov
Reported 2011-10-26 05:08:22 PDT
Execution line in selected call frame should keep showing after toggling format source.
Attachments
Patch (5.12 KB, patch)
2011-10-26 05:34 PDT, Vsevolod Vlasov 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2011-10-26 05:34:40 PDT
Created attachment 112485 [details] Patch
Pavel Podivilov
Comment 2 2011-10-26 07:18:34 PDT
Comment on attachment 112485 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112485&action=review > LayoutTests/inspector/debugger/selected-call-frame-after-formatting-source.html:50 > +<p>Tests execution line in selected call frame keeps showing after formatting source..</p> I think it actually tests that selected call frame does not change when pretty-print is toggled.
Pavel Feldman
Comment 3 2011-10-26 08:33:38 PDT
Comment on attachment 112485 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112485&action=review > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:-315 > - if (WebInspector.debuggerModel.callFrames) So we are not rebuilding call frames now. Why?
Vsevolod Vlasov
Comment 4 2011-10-26 15:18:31 PDT
Comment on attachment 112485 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112485&action=review >> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:-315 >> - if (WebInspector.debuggerModel.callFrames) > > So we are not rebuilding call frames now. Why? They are already correctly updated based on events from rawSourceCodes. Meanwhile calling debuggerPaused is bad because it resets selectedCallFrame to the top of the stack.
Yury Semikhatsky
Comment 5 2011-10-27 00:29:25 PDT
Comment on attachment 112485 [details] Patch Please update test description as Pavel suggests before landing.
Vsevolod Vlasov
Comment 6 2011-10-27 04:49:44 PDT
Committed r98549: <http://trac.webkit.org/changeset/98549>
Note You need to log in before you can comment on or make changes to this bug.