RESOLVED FIXED 70901
Name viewport change event consistently. 
https://bugs.webkit.org/show_bug.cgi?id=70901
Summary Name viewport change event consistently.
zalan
Reported 2011-10-26 03:38:55 PDT
Name viewport change event consistently.
Attachments
Patch (29.20 KB, patch)
2011-10-26 04:14 PDT, zalan 		kenneth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2011-10-26 04:14:58 PDT
Created attachment 112479 [details] Patch
WebKit Review Bot
Comment 2 2011-10-26 04:16:32 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Kenneth Rohde Christiansen
Comment 3 2011-10-26 04:23:42 PDT
Comment on attachment 112479 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112479&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:2194 > +void WebPageProxy::didChangeViewportProperties(const ViewportArguments& args) Will you change this one as well?
Kenneth Rohde Christiansen
Comment 4 2011-10-26 04:24:39 PDT
Comment on attachment 112479 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112479&action=review > Source/WebCore/page/Chrome.cpp:487 > -void Chrome::dispatchViewportDataDidChange(const ViewportArguments& arguments) const > +void Chrome::dispatchViewportPropertiesDidChange(const ViewportArguments& arguments) const Just to make sure, why isnt this called dispatchDidChangeViewportProperties? OR why the didChange* vs the *DidChange? Consistent with WebKit2?
zalan
Comment 5 2011-10-26 04:39:08 PDT
(In reply to comment #4) > (From update of attachment 112479 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=112479&action=review > > > Source/WebCore/page/Chrome.cpp:487 > > -void Chrome::dispatchViewportDataDidChange(const ViewportArguments& arguments) const > > +void Chrome::dispatchViewportPropertiesDidChange(const ViewportArguments& arguments) const > > Just to make sure, why isnt this called dispatchDidChangeViewportProperties? OR why the > > didChange* vs the *DidChange? Consistent with WebKit2? WebKit2 has the style of didChangeSomething (DidChangeScrollbarsForMainFrame) while WebCore convention is more like somethingDidChange (scrollbarsModeDidChange).
Simon Hausmann
Comment 6 2011-10-26 06:39:46 PDT
Committed r98472: <http://trac.webkit.org/changeset/98472>
Note You need to log in before you can comment on or make changes to this bug.