Bug 70880 – Fix editing/selection/caret-mode-paragraph-keys-navigation.html for Mac

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Ryosuke Niwa]

editing/selection/caret-mode-paragraph-keys-navigation.html assumes ctrlKey enable word-boundary movement, which isn't case on Mac. We need to use altKey on Mac instead.

[Ryosuke Niwa]

Created attachment 112467 [details]
fixes the test

[Eric Seidel (no email)]

Comment on attachment 112467 [details]
fixes the test

OK.  What about Apple Mac?

[Kent Tamura]

Comment on attachment 112467 [details]
fixes the test

View in context: https://bugs.webkit.org/attachment.cgi?id=112467&action=review

> LayoutTests/editing/selection/caret-mode-paragraph-keys-navigation.html:43
> +  var modifierForWordGranularity = navigator.platform == "MacIntel" ? "altKey" : "ctrlKey";

eventSender.keyDown() can have a single modifier name for such platform-dependent keys . We already have the followings:
  "addSelectionKey" (equivalent to metaKey in Mac, ctrlKey in Windows)
  "rangeSelectionKey" (equivalent to shiftKey in Mac and Windows)
(From http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree)

[Eric Seidel (no email)]

Why is this only failing on Chromium Mac?  Is it skipped on AppleMac?

[Ryosuke Niwa]

Comment on attachment 112467 [details]
fixes the test

View in context: https://bugs.webkit.org/attachment.cgi?id=112467&action=review

>> LayoutTests/editing/selection/caret-mode-paragraph-keys-navigation.html:43
>> +  var modifierForWordGranularity = navigator.platform == "MacIntel" ? "altKey" : "ctrlKey";
> 
> eventSender.keyDown() can have a single modifier name for such platform-dependent keys . We already have the followings:
>   "addSelectionKey" (equivalent to metaKey in Mac, ctrlKey in Windows)
>   "rangeSelectionKey" (equivalent to shiftKey in Mac and Windows)
> (From http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree)

That might be a good idea.

[Ryosuke Niwa]

(In reply to comment #4)
> Why is this only failing on Chromium Mac?  Is it skipped on AppleMac?

According to the comment in Skipped, Apple Mac doesn't support the DRT method.

[WebKit Review Bot]

Comment on attachment 112467 [details]
fixes the test

Clearing flags on attachment: 112467

Committed r98457: <http://trac.webkit.org/changeset/98457>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.