Bug 70869 - Fix click-before-and-after-table.html for Chromium
Summary: Fix click-before-and-after-table.html for Chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-25 22:29 PDT by Ryosuke Niwa
Modified: 2011-10-27 21:24 PDT (History)
7 users (show)

See Also:


Attachments
fixes the test (5.05 KB, patch)
2011-10-25 22:33 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch (4.03 KB, patch)
2011-10-27 14:36 PDT, Ryosuke Niwa
tony: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-10-25 22:29:45 PDT
click-before-and-after-table.html is skipped in Chromium due to some silly V8/JSC difference. We should fix this since the said test isn't testing JSC/V8 feature.
Comment 1 Ryosuke Niwa 2011-10-25 22:33:33 PDT
Created attachment 112449 [details]
fixes the test
Comment 2 WebKit Review Bot 2011-10-25 23:00:04 PDT
Comment on attachment 112449 [details]
fixes the test

Attachment 112449 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10208644

New failing tests:
editing/selection/click-before-and-after-table.html
http/tests/security/dataTransfer-set-data-file-url.html
Comment 3 Ryosuke Niwa 2011-10-25 23:20:49 PDT
Hm... odd. Alright, let's add PASS FAIL test expectation for now and see what happens.
Comment 4 Tony Chang 2011-10-26 10:04:57 PDT
Comment on attachment 112449 [details]
fixes the test

View in context: https://bugs.webkit.org/attachment.cgi?id=112449&action=review

The fix for the layout test looks fine.

> LayoutTests/platform/chromium/test_expectations.txt:-471
> -WONTFIX SKIP : platform/mac/editing/pasteboard/dataTransfer-set-data-file-url.html = FAIL
> -WONTFIX SKIP : http/tests/security/dataTransfer-set-data-file-url.html = FAIL

Does Chromium DRT implement window.objCPlugin?

> LayoutTests/platform/chromium/test_expectations.txt:-641
> -BUGWK60089 DEBUG : editing/selection/designmode-no-caret.html = CRASH FAIL

This test still appears to be failing everywhere (but no longer crashing).  Can you merge this with the lines above instead?
Comment 5 Ryosuke Niwa 2011-10-26 10:18:13 PDT
(In reply to comment #4)
> > LayoutTests/platform/chromium/test_expectations.txt:-471
> > -WONTFIX SKIP : platform/mac/editing/pasteboard/dataTransfer-set-data-file-url.html = FAIL
> > -WONTFIX SKIP : http/tests/security/dataTransfer-set-data-file-url.html = FAIL
> 
> Does Chromium DRT implement window.objCPlugin?

These tests no longer require window.objCPlugin.

> > LayoutTests/platform/chromium/test_expectations.txt:-641
> > -BUGWK60089 DEBUG : editing/selection/designmode-no-caret.html = CRASH FAIL
> 
> This test still appears to be failing everywhere (but no longer crashing).  Can you merge this with the lines above instead?

I've already fixed it in one of my unreviewed changes :)
Comment 6 Ryosuke Niwa 2011-10-27 14:36:38 PDT
Created attachment 112756 [details]
Patch
Comment 7 WebKit Review Bot 2011-10-27 15:39:43 PDT
Comment on attachment 112756 [details]
Patch

Attachment 112756 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10223925

New failing tests:
editing/selection/click-before-and-after-table.html
Comment 8 Ryosuke Niwa 2011-10-27 21:24:40 PDT
Committed r98685: <http://trac.webkit.org/changeset/98685>