Use enum instead of bool to represent -webkit-column-span property.
Created attachment 112443 [details] Patch
Comment on attachment 112443 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112443&action=review > Source/WebCore/rendering/style/RenderStyleConstants.h:86 > +enum ColumnSpan { ColumnSpanOne = 0, ColumnSpanAll}; Not sure I see the value in specifying "= 0" here and not specifying "= 1". I’d leave off the "= 0" myself.
Comment on attachment 112443 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112443&action=review >> Source/WebCore/rendering/style/RenderStyleConstants.h:86 >> +enum ColumnSpan { ColumnSpanOne = 0, ColumnSpanAll}; > > Not sure I see the value in specifying "= 0" here and not specifying "= 1". I’d leave off the "= 0" myself. The reason I do it this way is to make the behavior clear when used in logical statements. I'm not sure that the C++ spec defines the first enum value to be zero, even though most compilers do generate values that way. By doing this I am trying to express that ColumSpanOne is always logically false, and ColumnSpanAll is logically true (!0). Is that logic flawed? It seems to come up in reviews from time to time.
Comment on attachment 112443 [details] Patch Clearing flags on attachment: 112443 Committed r98748: <http://trac.webkit.org/changeset/98748>
All reviewed patches have been landed. Closing bug.