Bug 70865 - JSEventTarget.cpp has a bunch of unnessary includes
Summary: JSEventTarget.cpp has a bunch of unnessary includes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-25 18:06 PDT by Adam Barth
Modified: 2011-10-26 10:31 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.19 KB, patch)
2011-10-25 18:08 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (5.19 KB, patch)
2011-10-25 18:27 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-10-25 18:06:33 PDT 
JSEventTarget.cpp has a bunch of unnessary includes
Comment 1 Adam Barth 2011-10-25 18:08:52 PDT 
Created attachment 112438 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-10-25 18:18:08 PDT 
Comment on attachment 112438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112438&action=review

> Source/WebCore/webaudio/JavaScriptAudioNode.h:49
> +// FIXME: AudioNode should be introduced at the base of the inheritance hierarchy (i.e., as a base class for AudioNode).

I'm not sure this makes sense?  You use AudioNode twice?
Comment 3 Adam Barth 2011-10-25 18:20:35 PDT 
> I'm not sure this makes sense?  You use AudioNode twice?

Yeah, I meant EventTarget the first time.
Comment 4 Adam Barth 2011-10-25 18:27:06 PDT 
Created attachment 112440 [details]
Patch for landing
Comment 5 WebKit Review Bot 2011-10-25 20:06:07 PDT 
Comment on attachment 112440 [details]
Patch for landing

Clearing flags on attachment: 112440

Committed r98427: <http://trac.webkit.org/changeset/98427>
Comment 6 WebKit Review Bot 2011-10-25 20:06:11 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Chris Rogers 2011-10-25 21:49:28 PDT 
Adam, FYI, Dominic and I have been talking about making JavaScriptAudioNode *not* be an EventTarget at all.  But instead use a Callback instead of EventListener
Comment 8 Adam Barth 2011-10-25 22:01:02 PDT 
Even better.

BTW, is it too late to rename the interface?  Having "JavaScript" in an interface name doesn't make much sense.  (Imagine Python bindings for the DOM.)
Comment 9 Chris Rogers 2011-10-26 10:23:42 PDT 
(In reply to comment #8)
> Even better.
> 
> BTW, is it too late to rename the interface?  Having "JavaScript" in an interface name doesn't make much sense.  (Imagine Python bindings for the DOM.)

I agree that the name isn't the best.  Unfortunately, JavaScriptAudioNode is one of the most common nodes people are using, so if we do change the name then I want to provide a deprecation path where the old name (as well as the new name) continues to work for a period of time.
Comment 10 Eric Seidel (no email) 2011-10-26 10:31:52 PDT 
Deprecation path seems OK.  They talk about how the future is always larger than the past. :)  So seems like if we ever want to have other languages in the browser, JavaScript is a bad interface prefix. :)