Bug 70864 - Embedded PDFs should be known to DocumentLoader
Summary: Embedded PDFs should be known to DocumentLoader
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: PDF (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-25 17:22 PDT by Alexey Proskuryakov
Modified: 2011-10-26 11:12 PDT (History)
0 users

See Also:

Attachments
proposed patch (20.62 KB, patch)
2011-10-25 17:32 PDT, Alexey Proskuryakov 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-10-25 17:22:12 PDT 
Why? To better support Save As or saving to Web archive.
Comment 1 Alexey Proskuryakov 2011-10-25 17:32:08 PDT 
Created attachment 112431 [details]
proposed patch

Perhaps it should ultimately be the job of PluginController implementation to save plug-in resources as necessary. But it's not clear to me how to structure that, and PDF is the only plug-in that currently needs this anyway.
Comment 2 Darin Adler 2011-10-26 10:21:43 PDT 
Comment on attachment 112431 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112431&action=review

r=me but I’d really like you to explicitly state why this should be done

> Source/WebKit2/ChangeLog:3
> +        Embedded PDFs should be known to DocumentLoader

This bug title doesn’t say why they should be known to DocumentLoader. And nothing in the change log says why either.
Comment 3 Alexey Proskuryakov 2011-10-26 10:48:44 PDT 
Bug description has the rationale.
Comment 4 Alexey Proskuryakov 2011-10-26 11:12:27 PDT 
Committed <http://trac.webkit.org/changeset/98503>.