Bug 70855 - EventTargetFactory.in is not sorted
Summary: EventTargetFactory.in is not sorted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-25 14:55 PDT by Adam Barth
Modified: 2011-10-25 16:42 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.10 KB, patch)
2011-10-25 14:57 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-10-25 14:55:33 PDT 
EventTargetFactory.in is not sorted
Comment 1 Adam Barth 2011-10-25 14:57:43 PDT 
Created attachment 112411 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-10-25 15:12:33 PDT 
Comment on attachment 112411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112411&action=review

> PerformanceTests/ChangeLog:8
> +        Add a microbenchmark for wrapping event target.

And what is the perf effect of your previous change?  Any?
Comment 3 Adam Barth 2011-10-25 15:15:49 PDT 
== Unsorted ==

abarth@quadzen:~/svn/webkit$ ./out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree file:///Users/abarth/svn/webkit/PerformanceTests/Bindings/event-target-wrapper.html 
Content-Type: text/plain
Running 20 times
Ignoring warm-up run (612)
602
602
599
599
599
601
600
600
600
599
598
599
599
602
605
603
605
608
610
603

avg 601.65
median 600.5
stdev 3.1666228067138023
min 598
max 610

#EOF

== Sorted ==


abarth@quadzen:~/svn/webkit$ ./out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree file:///Users/abarth/svn/webkit/PerformanceTests/Bindings/event-target-wrapper.html 
Content-Type: text/plain
Running 20 times
Ignoring warm-up run (609)
603
600
599
599
598
600
599
599
599
598
601
600
602
601
599
601
600
600
601
600

avg 599.95
median 600
stdev 1.243985530462473
min 598
max 603

#EOF
Comment 4 Adam Barth 2011-10-25 15:17:17 PDT 
> And what is the perf effect of your previous change?  Any?

Ah, that I didn't measure.  I'm pretty sure it's zero though because it's doing the same thing as before (one virtual function call and one branch per interface).
Comment 5 WebKit Review Bot 2011-10-25 16:42:45 PDT 
Comment on attachment 112411 [details]
Patch

Clearing flags on attachment: 112411

Committed r98412: <http://trac.webkit.org/changeset/98412>
Comment 6 WebKit Review Bot 2011-10-25 16:42:49 PDT 
All reviewed patches have been landed.  Closing bug.