Bug 70855 – EventTargetFactory.in is not sorted

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

EventTargetFactory.in is not sorted

[Adam Barth]

Created attachment 112411 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 112411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112411&action=review

> PerformanceTests/ChangeLog:8
> +        Add a microbenchmark for wrapping event target.

And what is the perf effect of your previous change?  Any?

[Adam Barth]

== Unsorted ==

abarth@quadzen:~/svn/webkit$ ./out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree file:///Users/abarth/svn/webkit/PerformanceTests/Bindings/event-target-wrapper.html 
Content-Type: text/plain
Running 20 times
Ignoring warm-up run (612)
602
602
599
599
599
601
600
600
600
599
598
599
599
602
605
603
605
608
610
603

avg 601.65
median 600.5
stdev 3.1666228067138023
min 598
max 610

#EOF

== Sorted ==


abarth@quadzen:~/svn/webkit$ ./out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree file:///Users/abarth/svn/webkit/PerformanceTests/Bindings/event-target-wrapper.html 
Content-Type: text/plain
Running 20 times
Ignoring warm-up run (609)
603
600
599
599
598
600
599
599
599
598
601
600
602
601
599
601
600
600
601
600

avg 599.95
median 600
stdev 1.243985530462473
min 598
max 603

#EOF

[Adam Barth]

> And what is the perf effect of your previous change?  Any?

Ah, that I didn't measure.  I'm pretty sure it's zero though because it's doing the same thing as before (one virtual function call and one branch per interface).

[WebKit Review Bot]

Comment on attachment 112411 [details]
Patch

Clearing flags on attachment: 112411

Committed r98412: <http://trac.webkit.org/changeset/98412>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.