WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
70853
Make MutationObserverEntry a class instead of a struct to fix clang build
https://bugs.webkit.org/show_bug.cgi?id=70853
Summary
Make MutationObserverEntry a class instead of a struct to fix clang build
Adam Klein
Reported
2011-10-25 14:38:10 PDT
Make MutationObserverEntry a class instead of a struct to fix clang build
Attachments
Patch
(1.37 KB, patch)
2011-10-25 14:39 PDT
,
Adam Klein
no flags
Details
Formatted Diff
Diff
Patch
(1.32 KB, patch)
2011-10-25 15:06 PDT
,
Adam Klein
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Adam Klein
Comment 1
2011-10-25 14:39:36 PDT
Created
attachment 112406
[details]
Patch
Ryosuke Niwa
Comment 2
2011-10-25 14:45:52 PDT
Comment on
attachment 112406
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=112406&action=review
> Source/WebCore/dom/NodeRareData.h:93 > +class MutationObserverEntry { > +public:
We should probably make observer and options private if we're making this a class.
Adam Klein
Comment 3
2011-10-25 14:50:23 PDT
Comment on
attachment 112406
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=112406&action=review
>> Source/WebCore/dom/NodeRareData.h:93 >> +public: > > We should probably make observer and options private if we're making this a class.
We're "making it a class" only in the sense that we're using the keyword "class" here to quiet the compiler. It's still logically a struct with a few helper methods. If you'd rather I change the forward-declaration I can do that too; I mainly didn't do that because I didn't know how to sort it with the rest of the forward decls there :)
Ryosuke Niwa
Comment 4
2011-10-25 15:00:11 PDT
(In reply to
comment #3
)
> If you'd rather I change the forward-declaration I can do that too; I mainly didn't do that because I didn't know how to sort it with the rest of the forward decls there :)
Okay, then I'd prefer that. Structs should probably appear after classes.
Adam Klein
Comment 5
2011-10-25 15:06:24 PDT
Created
attachment 112413
[details]
Patch
WebKit Review Bot
Comment 6
2011-10-25 15:54:58 PDT
Comment on
attachment 112413
[details]
Patch Clearing flags on attachment: 112413 Committed
r98402
: <
http://trac.webkit.org/changeset/98402
>
WebKit Review Bot
Comment 7
2011-10-25 15:55:03 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug