Bug 7085 – History->Back does not work while viewing PDF

• Status: ASSIGNED
• Component: PDF

[David Kilzer (:ddkilzer)]

Summary:

The History->Back menu choice doesn't work after viewing a PDF.  (Note that the "Back Arrow" button on Safari itself works, though.)

Steps to Reproduce: 

1. Open Safari+WebKit ToT.  (I used revision r12570.)
2. Open a PDF URL like this: http://developer.apple.com/hardware/ipod/ipodnotereader.pdf
3. Select "Back" from the "History" menu.

Expected Results: 

Safari should go back one page out of the PDF.

Actual Results: 

Safari does nothing.  You must click the "Back Arrow" button in Safari itself to make the page go back.

Regression: 

This is a regression.  This procedure works on Safari 2.0.3 (417.8) on 10.4.4.

Notes: 

None.

[John Sullivan]

Radar bug <rdar://problem/4403078> is about problems with PDFs vs. Back/Forward, but is not a regression.

[Darin Adler]

What's happening here is that the menu item says goBack: but does not specify a target. The PDFView is in the responder chain and it has a goBack: method.

[David Kilzer (:ddkilzer)]

Bug 7102 may be related to this bug as it involves viewing a PDF, then hitting the "Back" button.

[John Sullivan]

These issues are also in Radar as <rdar://problem/4347183>. The basic problem is that when the PDF view is focused, it steals "goBack:" from the menu and keyboard equivalent, and conversely "goBack:" from the toolbar is never sent to the PDF view. So the two ways to invoke "Back" each have different problems interacting with PDFs.

The only aspect of this that's a regression is that due to other fixes, the PDF view is (correctly) focused more often than it used to be, so stealing "goBack:" from the menu and keyboard equivalent is more common.

[David Kilzer (:ddkilzer)]

ToT WebKit r21170 behaves the same as shipping Safari 2.0.4 (419.3) on Mac OS X 10.4.9 (8P135) now:

Works:
- Back button on browser
- Cmd-Left-Arrow
- Backspace

Does not work:
- History->Back menu item
- Cmd-[ (mapped to History->Back menu item)