RESOLVED FIXED 70846
Flesh out WKBrowsingContextLoadDelegate a bit 
https://bugs.webkit.org/show_bug.cgi?id=70846
Summary Flesh out WKBrowsingContextLoadDelegate a bit
Sam Weinig
Reported 2011-10-25 13:49:19 PDT
Flesh out WKBrowsingContextLoadDelegate a bit
Attachments
Patch (5.57 KB, patch)
2011-10-25 13:50 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (17.80 KB, patch)
2011-10-25 15:29 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-10-25 13:50:13 PDT
Created attachment 112394 [details] Patch
Anders Carlsson
Comment 2 2011-10-25 13:52:16 PDT
Comment on attachment 112394 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112394&action=review > Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm:218 > + WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo; > + [browsingContext.loadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:browsingContext]; > +} This does not check that the delegate responds to the selector. The code needs to do that, and possibly cache the result as well. > Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm:257 > + WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo; > + [browsingContext.loadDelegate browsingContextControllerDidFailLoad:browsingContext withError:(NSError *)cfError.get()]; Ditto.
Sam Weinig
Comment 3 2011-10-25 15:29:53 PDT
Created attachment 112415 [details] Patch
Sam Weinig
Comment 4 2011-10-25 15:30:38 PDT
Now with a test!
Sam Weinig
Comment 5 2011-10-25 15:34:50 PDT
Committed r98399: <http://trac.webkit.org/changeset/98399>
Note You need to log in before you can comment on or make changes to this bug.