Bug 70846 - Flesh out WKBrowsingContextLoadDelegate a bit
Summary: Flesh out WKBrowsingContextLoadDelegate a bit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-25 13:49 PDT by Sam Weinig
Modified: 2011-10-25 15:34 PDT (History)
0 users

See Also:

Attachments
Patch (5.57 KB, patch)
2011-10-25 13:50 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (17.80 KB, patch)
2011-10-25 15:29 PDT, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-10-25 13:49:19 PDT 
Flesh out WKBrowsingContextLoadDelegate a bit
Comment 1 Sam Weinig 2011-10-25 13:50:13 PDT 
Created attachment 112394 [details]
Patch
Comment 2 Anders Carlsson 2011-10-25 13:52:16 PDT 
Comment on attachment 112394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112394&action=review

> Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm:218
> +    WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
> +    [browsingContext.loadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:browsingContext];
> +}

This does not check that the delegate responds to the selector. The code needs to do that, and possibly cache the result as well.

> Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm:257
> +    WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
> +    [browsingContext.loadDelegate browsingContextControllerDidFailLoad:browsingContext withError:(NSError *)cfError.get()];

Ditto.
Comment 3 Sam Weinig 2011-10-25 15:29:53 PDT 
Created attachment 112415 [details]
Patch
Comment 4 Sam Weinig 2011-10-25 15:30:38 PDT 
Now with a test!
Comment 5 Sam Weinig 2011-10-25 15:34:50 PDT 
Committed r98399: <http://trac.webkit.org/changeset/98399>