Bug 70834 - build-webkit --clean should only clean build directory for CMake-based ports
Summary: build-webkit --clean should only clean build directory for CMake-based ports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-25 12:01 PDT by Daniel Bates
Modified: 2011-10-25 12:36 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2011-10-25 12:10 PDT, Daniel Bates 		tonikitoo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2011-10-25 12:01:45 PDT 
Currently for CMake-based ports build-webkit --clean will both clean the build directory and build WebKit. Instead, the --clean argument should only clean the build directory as per its description in the usage message of build-webkit.
Comment 1 Daniel Bates 2011-10-25 12:10:51 PDT 
Created attachment 112371 [details]
Patch
Comment 2 Leandro Pereira 2011-10-25 12:22:42 PDT 
Comment on attachment 112371 [details]
Patch

LGTM.
Comment 3 Antonio Gomes 2011-10-25 12:24:36 PDT 
Comment on attachment 112371 [details]
Patch

<tonikitoo> acidx, leandro would you mind? https://bugs.webkit.org/show_bug.cgi?id=70834
(...)
<acidx> tonikitoo: LGTM.
Comment 4 Daniel Bates 2011-10-25 12:36:20 PDT 
Committed r98377: <http://trac.webkit.org/changeset/98377>