WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
70834
build-webkit --clean should only clean build directory for CMake-based ports
https://bugs.webkit.org/show_bug.cgi?id=70834
Summary
build-webkit --clean should only clean build directory for CMake-based ports
Daniel Bates
Reported
2011-10-25 12:01:45 PDT
Currently for CMake-based ports build-webkit --clean will both clean the build directory and build WebKit. Instead, the --clean argument should only clean the build directory as per its description in the usage message of build-webkit.
Attachments
Patch
(1.58 KB, patch)
2011-10-25 12:10 PDT
,
Daniel Bates
tonikitoo
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2011-10-25 12:10:51 PDT
Created
attachment 112371
[details]
Patch
Leandro Pereira
Comment 2
2011-10-25 12:22:42 PDT
Comment on
attachment 112371
[details]
Patch LGTM.
Antonio Gomes
Comment 3
2011-10-25 12:24:36 PDT
Comment on
attachment 112371
[details]
Patch <tonikitoo> acidx, leandro would you mind?
https://bugs.webkit.org/show_bug.cgi?id=70834
(...) <acidx> tonikitoo: LGTM.
Daniel Bates
Comment 4
2011-10-25 12:36:20 PDT
Committed
r98377
: <
http://trac.webkit.org/changeset/98377
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug