Bug 70818 - [chromium] WebGraphicsContext3D setVisibilityCHROMIUM extension changed to pure virtual.
Summary: [chromium] WebGraphicsContext3D setVisibilityCHROMIUM extension changed to pu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-25 10:01 PDT by Michal Mocny
Modified: 2011-10-25 13:29 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.89 KB, patch)
2011-10-25 10:03 PDT, Michal Mocny 		no flags Details | Formatted Diff | Diff
Patch (1.41 KB, patch)
2011-10-25 10:15 PDT, Michal Mocny 		no flags Details | Formatted Diff | Diff
Patch (1.41 KB, patch)
2011-10-25 10:34 PDT, Michal Mocny 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Mocny 2011-10-25 10:01:43 PDT 
WebGraphicsContext3D setVisibilityCHROMIUM extension changed to pure virtual.
Comment 1 Michal Mocny 2011-10-25 10:03:13 PDT 
Created attachment 112349 [details]
Patch
Comment 2 WebKit Review Bot 2011-10-25 10:05:16 PDT 
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 3 Michal Mocny 2011-10-25 10:08:28 PDT 
This patch is the last of the three patch set:
1. https://bugs.webkit.org/show_bug.cgi?id=70635
2. http://codereview.chromium.org/8373006
3. This patch
Comment 4 Michal Mocny 2011-10-25 10:10:15 PDT 
Also, WebKit Sheriff (jchaffraix) LGTMed the chromium_rev roll.
Comment 5 Nat Duca 2011-10-25 10:11:28 PDT 
Comment on attachment 112349 [details]
Patch

Unofficially looks good. I'll see if I can rev the deps.
Comment 6 Michal Mocny 2011-10-25 10:15:06 PDT 
Created attachment 112352 [details]
Patch
Comment 7 Michal Mocny 2011-10-25 10:15:50 PDT 
Removed the deps roll from this patch.
Comment 8 Kenneth Russell 2011-10-25 10:22:17 PDT 
Comment on attachment 112352 [details]
Patch

Looks fine as long as it compiles. r=me
Comment 9 WebKit Review Bot 2011-10-25 10:29:10 PDT 
Comment on attachment 112352 [details]
Patch

Attachment 112352 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10213257
Comment 10 Michal Mocny 2011-10-25 10:34:19 PDT 
Created attachment 112357 [details]
Patch
Comment 11 Kenneth Russell 2011-10-25 11:20:57 PDT 
Comment on attachment 112357 [details]
Patch

OK.
Comment 12 WebKit Review Bot 2011-10-25 13:29:31 PDT 
Comment on attachment 112357 [details]
Patch

Clearing flags on attachment: 112357

Committed r98384: <http://trac.webkit.org/changeset/98384>
Comment 13 WebKit Review Bot 2011-10-25 13:29:36 PDT 
All reviewed patches have been landed.  Closing bug.