Bug 70812 - Web Inspector: JS exception in JavaScriptSourceFrame.onShowPopover/showObjectPopover()
Summary: Web Inspector: JS exception in JavaScriptSourceFrame.onShowPopover/showObject...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2011-10-25 05:02 PDT by Andrey Kosyakov
Modified: 2011-10-25 06:02 PDT (History)
11 users (show)

See Also:


Attachments
patch (1.51 KB, patch)
2011-10-25 05:05 PDT, Andrey Kosyakov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2011-10-25 05:02:59 PDT
There's a race condition in showObjectPopover() -- sometimes, popover may be hidden while a popover expression is being evaluated in the inspected page. In this case, _highlightElement becomes undefined and this._highlightElement.addStyleClass() call in showObjectPopover() results in an exception.
Comment 1 Andrey Kosyakov 2011-10-25 05:05:05 PDT
Created attachment 112323 [details]
patch
Comment 2 Andrey Kosyakov 2011-10-25 06:02:53 PDT
A variation of the patch landed manually as r98333: http://trac.webkit.org/changeset/98333