Bug 70797 - Simplify url accessors on WKBrowsingContextController
Summary: Simplify url accessors on WKBrowsingContextController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-24 19:37 PDT by Sam Weinig
Modified: 2011-10-24 19:46 PDT (History)
1 user (show)

See Also:

Attachments
Patch (7.57 KB, patch)
2011-10-24 19:40 PDT, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-10-24 19:37:56 PDT 
Simplify url accessors on WKBrowsingContextController
Comment 1 Sam Weinig 2011-10-24 19:40:49 PDT 
Created attachment 112293 [details]
Patch
Comment 2 WebKit Review Bot 2011-10-24 19:42:06 PDT 
Attachment 112293 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/WebPageProxy.cpp:609:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2011-10-24 19:42:29 PDT 
Comment on attachment 112293 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112293&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:615
> +    }
> +}

This needs to return something for the default case...maybe a null string?
Comment 4 Sam Weinig 2011-10-24 19:46:19 PDT 
Committed r98311: <http://trac.webkit.org/changeset/98311>