RESOLVED FIXED 70797
Simplify url accessors on WKBrowsingContextController 
https://bugs.webkit.org/show_bug.cgi?id=70797
Summary Simplify url accessors on WKBrowsingContextController
Sam Weinig
Reported 2011-10-24 19:37:56 PDT
Simplify url accessors on WKBrowsingContextController
Attachments
Patch (7.57 KB, patch)
2011-10-24 19:40 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-10-24 19:40:49 PDT
Created attachment 112293 [details] Patch
WebKit Review Bot
Comment 2 2011-10-24 19:42:06 PDT
Attachment 112293 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/WebPageProxy.cpp:609: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2011-10-24 19:42:29 PDT
Comment on attachment 112293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112293&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:615 > + } > +} This needs to return something for the default case...maybe a null string?
Sam Weinig
Comment 4 2011-10-24 19:46:19 PDT
Committed r98311: <http://trac.webkit.org/changeset/98311>
Note You need to log in before you can comment on or make changes to this bug.