WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
70760
Plugin tests are failing after switching WK2 to NRWT
https://bugs.webkit.org/show_bug.cgi?id=70760
Summary
Plugin tests are failing after switching WK2 to NRWT
Eric Seidel (no email)
Reported
2011-10-24 13:57:59 PDT
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r98243%20(15595)/results.html
Plugin tests are failing after switching WK2 to NRWT This is due to this FIXME in ORWT: # FIXME: We build both DumpRenderTree and WebKitTestRunner for # WebKitTestRunner runs becuase DumpRenderTree still includes # the DumpRenderTreeSupport module and the TestNetscapePlugin. # These two projects should be factored out into their own # projects. buildDumpTool("DumpRenderTree"); buildDumpTool("WebKitTestRunner") if $useWebKitTestRunner; I'll move that hack into build-webkitestrunner instead of ORWT.
Attachments
Patch
(1.80 KB, patch)
2011-10-24 14:10 PDT
,
Eric Seidel (no email)
simon.fraser
: review+
simon.fraser
: commit-queue+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2011-10-24 13:58:45 PDT
***
Bug 70759
has been marked as a duplicate of this bug. ***
Eric Seidel (no email)
Comment 2
2011-10-24 14:09:04 PDT
Actually, doing this in build-webkittestrunner turned out to be a pain. Bleh.
Eric Seidel (no email)
Comment 3
2011-10-24 14:10:05 PDT
Created
attachment 112243
[details]
Patch
Eric Seidel (no email)
Comment 4
2011-10-24 15:25:09 PDT
Committed
r98288
: <
http://trac.webkit.org/changeset/98288
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug