Bug 70760 - Plugin tests are failing after switching WK2 to NRWT
Summary: Plugin tests are failing after switching WK2 to NRWT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
: 70759 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-10-24 13:57 PDT by Eric Seidel (no email)
Modified: 2011-10-24 15:25 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.80 KB, patch)
2011-10-24 14:10 PDT, Eric Seidel (no email) 		simon.fraser: review+
simon.fraser: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-10-24 13:57:59 PDT 
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r98243%20(15595)/results.html

Plugin tests are failing after switching WK2 to NRWT

This is due to this FIXME in ORWT:
   # FIXME: We build both DumpRenderTree and WebKitTestRunner for
   # WebKitTestRunner runs becuase DumpRenderTree still includes
   # the DumpRenderTreeSupport module and the TestNetscapePlugin.
   # These two projects should be factored out into their own
   # projects.
   buildDumpTool("DumpRenderTree");
   buildDumpTool("WebKitTestRunner") if $useWebKitTestRunner;

I'll move that hack into build-webkitestrunner instead of ORWT.
Comment 1 Eric Seidel (no email) 2011-10-24 13:58:45 PDT 
*** Bug 70759 has been marked as a duplicate of this bug. ***
Comment 2 Eric Seidel (no email) 2011-10-24 14:09:04 PDT 
Actually, doing this in build-webkittestrunner turned out to be a pain.  Bleh.
Comment 3 Eric Seidel (no email) 2011-10-24 14:10:05 PDT 
Created attachment 112243 [details]
Patch
Comment 4 Eric Seidel (no email) 2011-10-24 15:25:09 PDT 
Committed r98288: <http://trac.webkit.org/changeset/98288>