Bug 70747 - check-webkit-style complains about WEBKIT_EXPORT in test/WebUnitTests.h
Summary: check-webkit-style complains about WEBKIT_EXPORT in test/WebUnitTests.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-24 11:28 PDT by Nat Duca
Modified: 2011-10-24 12:01 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.78 KB, patch)
2011-10-24 11:55 PDT, David Levin 		tony: review+
levin: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nat Duca 2011-10-24 11:28:16 PDT 
WebUnitTests.h has WEBKIT_EXPORT's for testing purposes.

This makes check-webkit-style sad.

On this bug, we discussed adding a WEBKIT_EXPORT_PRIVATE to avoid this:
https://bugs.webkit.org/show_bug.cgi?id=70688

However, the conclusion was that we should probably just make cws not complain about test/ exports.
Comment 1 David Levin 2011-10-24 11:55:08 PDT 
Created attachment 112221 [details]
Patch
Comment 2 Tony Chang 2011-10-24 11:56:55 PDT 
Comment on attachment 112221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112221&action=review

> Tools/Scripts/webkitpy/style/checkers/cpp.py:1607
>                    'WEBKIT_EXPORT should only appear in the chromium public directory.')

Nit: Do we want to update the error text?
Comment 3 David Levin 2011-10-24 11:59:33 PDT 
Comment on attachment 112221 [details]
Patch

ok I'll add " (or tests)"
Comment 4 David Levin 2011-10-24 12:01:34 PDT 
Committed as http://trac.webkit.org/changeset/98264