Bug 70746 - Use StringBuilder in CSSRuleList::rulesText()/CSSSelectorList::selectorsText()
Summary: Use StringBuilder in CSSRuleList::rulesText()/CSSSelectorList::selectorsText()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mihnea Ovidenie
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-24 11:25 PDT by Mihnea Ovidenie
Modified: 2011-10-24 14:00 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.21 KB, patch)
2011-10-24 11:57 PDT, Mihnea Ovidenie 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihnea Ovidenie 2011-10-24 11:25:27 PDT 
Improve performance in CSSRuleList::rulesText()/CSSSelectorList::selectorsText() by using StringBuilder instead of String.
Comment 1 Mihnea Ovidenie 2011-10-24 11:57:44 PDT 
Created attachment 112223 [details]
Patch
Comment 2 Tony Chang 2011-10-24 12:00:53 PDT 
Comment on attachment 112223 [details]
Patch

We should also switch over CSSRulesList::rulesText().
Comment 3 WebKit Review Bot 2011-10-24 14:00:32 PDT 
Comment on attachment 112223 [details]
Patch

Clearing flags on attachment: 112223

Committed r98281: <http://trac.webkit.org/changeset/98281>
Comment 4 WebKit Review Bot 2011-10-24 14:00:36 PDT 
All reviewed patches have been landed.  Closing bug.