Bug 70745 - Enable MEDIA_SOURCE feature for Chromium
Summary: Enable MEDIA_SOURCE feature for Chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 70767 71016
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-24 11:14 PDT by Aaron Colwell
Modified: 2011-10-27 07:11 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.15 KB, patch)
2011-10-24 11:18 PDT, Aaron Colwell
no flags Details | Formatted Diff | Diff
Patch (1.12 KB, patch)
2011-10-25 12:50 PDT, Aaron Colwell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Colwell 2011-10-24 11:14:17 PDT
Set the ENABLE_MEDIA_SOURCE feature define to 1 so the MediaSource API can be exposed in Chromium behind a command-line flag.
Comment 1 Aaron Colwell 2011-10-24 11:18:04 PDT
Created attachment 112216 [details]
Patch
Comment 2 WebKit Review Bot 2011-10-24 12:28:12 PDT
Comment on attachment 112216 [details]
Patch

Clearing flags on attachment: 112216

Committed r98266: <http://trac.webkit.org/changeset/98266>
Comment 3 WebKit Review Bot 2011-10-24 12:28:16 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 David Levin 2011-10-24 14:58:33 PDT
Broke the chromium build so rolled out.
Comment 5 Julien Chaffraix 2011-10-24 15:00:12 PDT
Here is the relevant part of the log:

12>webcore_bindings.lib(V8DerivedSources02.obj) : error LNK2001: unresolved external symbol "private: static bool WebCore::RuntimeEnabledFeatures::isMediaSourceEnabled" (?isMediaSourceEnabled@RuntimeEnabledFeatures@WebCore@@0_NA)
12>.\build\Release\TestWebKitAPI.exe : fatal error LNK1120: 1 unresolved externals
12>Build log was saved at "file://e:\google-windows-1\chromium-win-release\build\Source\WebKit\chromium\build\Release\obj\TestWebKitAPI\BuildLog.htm"
12>TestWebKitAPI - 2 error(s), 0 warning(s)
13>Linking...
14>webcore_bindings.lib(V8DerivedSources02.obj) : error LNK2001: unresolved external symbol "private: static bool WebCore::RuntimeEnabledFeatures::isMediaSourceEnabled" (?isMediaSourceEnabled@RuntimeEnabledFeatures@WebCore@@0_NA)
14>.\build\Release\DumpRenderTree.exe : fatal error LNK1120: 1 unresolved externals
14>Build log was saved at "file://e:\google-windows-1\chromium-win-release\build\Source\WebKit\chromium\build\Release\obj\DumpRenderTree\BuildLog.htm"
14>DumpRenderTree - 2 error(s), 0 warning(s)
13>webcore_bindings.lib(V8DerivedSources02.obj) : error LNK2001: unresolved external symbol "private: static bool WebCore::RuntimeEnabledFeatures::isMediaSourceEnabled" (?isMediaSourceEnabled@RuntimeEnabledFeatures@WebCore@@0_NA)
13>.\build\Release\webkit_unit_tests.exe : fatal error LNK1120: 1 unresolved externals
13>Build log was saved at "file://e:\google-windows-1\chromium-win-release\build\Source\WebKit\chromium\build\Release\obj\webkit_unit_tests\BuildLog.htm"
13>webkit_unit_tests - 2 error(s), 0 warning(s)

Full log: http://build.webkit.org/builders/Chromium%20Win%20Release/builds/33707/steps/compile-webkit/logs/stdio
Comment 6 Aaron Colwell 2011-10-25 12:50:41 PDT
Created attachment 112378 [details]
Patch
Comment 7 Aaron Colwell 2011-10-25 12:52:06 PDT
Comment on attachment 112378 [details]
Patch

reuploading the original patch. I believe the Windows build problems that caused it to get reverted was because Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp wasn't getting rebuilt by the Windows bots.
Comment 8 David Levin 2011-10-25 13:16:33 PDT
Comment on attachment 112378 [details]
Patch

I'm not cq+ because I can't help if there are difficulties with landing this again.
Comment 9 WebKit Review Bot 2011-10-27 06:31:43 PDT
Comment on attachment 112378 [details]
Patch

Clearing flags on attachment: 112378

Committed r98562: <http://trac.webkit.org/changeset/98562>
Comment 10 WebKit Review Bot 2011-10-27 06:31:47 PDT
All reviewed patches have been landed.  Closing bug.