Bug 70745 – Enable MEDIA_SOURCE feature for Chromium

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Aaron Colwell]

Set the ENABLE_MEDIA_SOURCE feature define to 1 so the MediaSource API can be exposed in Chromium behind a command-line flag.

[Aaron Colwell]

Created attachment 112216 [details]
Patch

[WebKit Review Bot]

Comment on attachment 112216 [details]
Patch

Clearing flags on attachment: 112216

Committed r98266: <http://trac.webkit.org/changeset/98266>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[David Levin]

Broke the chromium build so rolled out.

[Julien Chaffraix]

Here is the relevant part of the log:

12>webcore_bindings.lib(V8DerivedSources02.obj) : error LNK2001: unresolved external symbol "private: static bool WebCore::RuntimeEnabledFeatures::isMediaSourceEnabled" (?isMediaSourceEnabled@RuntimeEnabledFeatures@WebCore@@0_NA)
12>.\build\Release\TestWebKitAPI.exe : fatal error LNK1120: 1 unresolved externals
12>Build log was saved at "file://e:\google-windows-1\chromium-win-release\build\Source\WebKit\chromium\build\Release\obj\TestWebKitAPI\BuildLog.htm"
12>TestWebKitAPI - 2 error(s), 0 warning(s)
13>Linking...
14>webcore_bindings.lib(V8DerivedSources02.obj) : error LNK2001: unresolved external symbol "private: static bool WebCore::RuntimeEnabledFeatures::isMediaSourceEnabled" (?isMediaSourceEnabled@RuntimeEnabledFeatures@WebCore@@0_NA)
14>.\build\Release\DumpRenderTree.exe : fatal error LNK1120: 1 unresolved externals
14>Build log was saved at "file://e:\google-windows-1\chromium-win-release\build\Source\WebKit\chromium\build\Release\obj\DumpRenderTree\BuildLog.htm"
14>DumpRenderTree - 2 error(s), 0 warning(s)
13>webcore_bindings.lib(V8DerivedSources02.obj) : error LNK2001: unresolved external symbol "private: static bool WebCore::RuntimeEnabledFeatures::isMediaSourceEnabled" (?isMediaSourceEnabled@RuntimeEnabledFeatures@WebCore@@0_NA)
13>.\build\Release\webkit_unit_tests.exe : fatal error LNK1120: 1 unresolved externals
13>Build log was saved at "file://e:\google-windows-1\chromium-win-release\build\Source\WebKit\chromium\build\Release\obj\webkit_unit_tests\BuildLog.htm"
13>webkit_unit_tests - 2 error(s), 0 warning(s)

Full log: http://build.webkit.org/builders/Chromium%20Win%20Release/builds/33707/steps/compile-webkit/logs/stdio

[Aaron Colwell]

Created attachment 112378 [details]
Patch

[Aaron Colwell]

Comment on attachment 112378 [details]
Patch

reuploading the original patch. I believe the Windows build problems that caused it to get reverted was because Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp wasn't getting rebuilt by the Windows bots.

[David Levin]

Comment on attachment 112378 [details]
Patch

I'm not cq+ because I can't help if there are difficulties with landing this again.

[WebKit Review Bot]

Comment on attachment 112378 [details]
Patch

Clearing flags on attachment: 112378

Committed r98562: <http://trac.webkit.org/changeset/98562>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.