Bug 70741 - Remove getOwnPropertySlotVirtual
Summary: Remove getOwnPropertySlotVirtual
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks: 67690
  Show dependency treegraph
 
Reported: 2011-10-24 10:42 PDT by Mark Hahnenberg
Modified: 2011-10-27 05:24 PDT (History)
5 users (show)

See Also:


Attachments
Patch (106.39 KB, patch)
2011-10-25 14:30 PDT, Mark Hahnenberg
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2011-10-24 10:42:33 PDT
Now that we have an entry in the MethodTable for both versions of getOwnPropertySlot, we can remove their virtual counterparts and replace all call sites with an explicit lookup in the MethodTable.
Comment 1 Mark Hahnenberg 2011-10-25 14:30:51 PDT
Created attachment 112404 [details]
Patch
Comment 2 Geoffrey Garen 2011-10-26 09:47:14 PDT
Comment on attachment 112404 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112404&action=review

r=me

> Source/JavaScriptCore/API/JSCallbackObject.h:178
> +    const MethodTable* methodTable() const
> +    {
> +        return Parent::methodTable();
> +    }

I believe "using Parent::methodTable;" would work here, and be slightly more precise about what you mean.
Comment 3 Mark Hahnenberg 2011-10-26 11:04:01 PDT
Committed r98501: <http://trac.webkit.org/changeset/98501>
Comment 4 Csaba Osztrogonác 2011-10-27 04:26:10 PDT
It seems it broke bindings-tests on all bot. Could you fix it, please?
Comment 5 Philippe Normand 2011-10-27 05:10:16 PDT
(In reply to comment #4)
> It seems it broke bindings-tests on all bot. Could you fix it, please?

Looks like the tests only need a reset. I can land it unless someone objects.
Comment 6 Philippe Normand 2011-10-27 05:24:46 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > It seems it broke bindings-tests on all bot. Could you fix it, please?
> 
> Looks like the tests only need a reset. I can land it unless someone objects.

Landed http://trac.webkit.org/changeset/98552