Bug 70740 - Remove putVirtual
Summary: Remove putVirtual
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks: 67690
  Show dependency tree / graph
 
Reported: 2011-10-24 10:39 PDT by Mark Hahnenberg
Modified: 2011-10-25 17:56 PDT (History)
3 users (show)

See Also:

Attachments
Patch (98.42 KB, patch)
2011-10-24 12:01 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (99.93 KB, patch)
2011-10-24 16:23 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (100.05 KB, patch)
2011-10-24 18:32 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (100.07 KB, patch)
2011-10-24 18:49 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2011-10-24 10:39:38 PDT 
Now that we have an entry in the MethodTable for both versions of put, we can remove their virtual counterparts and replace all call sites with an explicit lookup in the MethodTable.
Comment 1 Mark Hahnenberg 2011-10-24 12:01:48 PDT 
Created attachment 112227 [details]
Patch
Comment 2 Mark Hahnenberg 2011-10-24 16:23:55 PDT 
Created attachment 112272 [details]
Patch
Comment 3 Mark Hahnenberg 2011-10-24 18:32:28 PDT 
Created attachment 112289 [details]
Patch
Comment 4 Mark Hahnenberg 2011-10-24 18:49:46 PDT 
Created attachment 112291 [details]
Patch
Comment 5 Geoffrey Garen 2011-10-25 17:08:27 PDT 
Comment on attachment 112291 [details]
Patch

r=me
Comment 6 WebKit Review Bot 2011-10-25 17:56:09 PDT 
Comment on attachment 112291 [details]
Patch

Clearing flags on attachment: 112291

Committed r98415: <http://trac.webkit.org/changeset/98415>
Comment 7 WebKit Review Bot 2011-10-25 17:56:14 PDT 
All reviewed patches have been landed.  Closing bug.