WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
70738
Remove deletePropertyVirtual
https://bugs.webkit.org/show_bug.cgi?id=70738
Summary
Remove deletePropertyVirtual
Mark Hahnenberg
Reported
2011-10-24 10:35:18 PDT
Now that we have an entry in the MethodTable for both versions of deleteProperty, we can remove their virtual counterparts and replace all call sites with an explicit lookup in the MethodTable.
Attachments
Patch
(67.35 KB, patch)
2011-10-24 11:59 PDT
,
Mark Hahnenberg
no flags
Details
Formatted Diff
Diff
Patch
(68.68 KB, patch)
2011-10-24 16:19 PDT
,
Mark Hahnenberg
no flags
Details
Formatted Diff
Diff
Patch
(68.78 KB, patch)
2011-10-24 16:30 PDT
,
Mark Hahnenberg
ggaren
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1
2011-10-24 11:59:10 PDT
Created
attachment 112225
[details]
Patch
Mark Hahnenberg
Comment 2
2011-10-24 16:19:56 PDT
Created
attachment 112271
[details]
Patch
Mark Hahnenberg
Comment 3
2011-10-24 16:30:09 PDT
Created
attachment 112273
[details]
Patch
Geoffrey Garen
Comment 4
2011-10-25 17:09:14 PDT
Comment on
attachment 112273
[details]
Patch r=me
WebKit Review Bot
Comment 5
2011-10-25 18:16:37 PDT
Comment on
attachment 112273
[details]
Patch Rejecting
attachment 112273
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: n/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output:
http://queues.webkit.org/results/10213392
Adam Barth
Comment 6
2011-10-25 18:19:32 PDT
Comment on
attachment 112273
[details]
Patch I thought we had that problem licked.
WebKit Review Bot
Comment 7
2011-10-25 18:22:07 PDT
Comment on
attachment 112273
[details]
Patch Rejecting
attachment 112273
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm patching file Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.cpp Hunk #1 succeeded at 346 (offset -5 lines). patching file Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.h Hunk #1 succeeded at 87 with fuzz 1 (offset -1 lines). patching file Source/WebKit2/WebProcess/Plugins/Netscape/NPJSObject.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Geoffrey Garen', u'--f..." exit_code: 1 Full output:
http://queues.webkit.org/results/10210427
Mark Hahnenberg
Comment 8
2011-10-25 18:48:09 PDT
Committed
r98422
: <
http://trac.webkit.org/changeset/98422
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug