Bug 70737 - WebKit doesn't build with recent changes to libdispatch
Summary: WebKit doesn't build with recent changes to libdispatch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.7
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-10-24 10:24 PDT by Michael Saboff
Modified: 2011-10-24 13:56 PDT (History)
0 users

See Also:

Attachments
Proposed Papatch (6.77 KB, patch)
2011-10-24 11:11 PDT, Michael Saboff 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2011-10-24 10:24:54 PDT 
From <rdar://problem/10257323>.

Changes in libdispatch and dispatch.h are breaking builds of webkit due to defines in Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm.

The solution is to move mac dependent code to WebKitSystemInterface.
Comment 1 Michael Saboff 2011-10-24 11:11:57 PDT 
Created attachment 112215 [details]
Proposed Papatch

This patch depends on change set r98256 which is already checked in.  That change set is the updated WebKitSystemInterface libraries.
Comment 2 Geoffrey Garen 2011-10-24 12:05:33 PDT 
Comment on attachment 112215 [details]
Proposed Papatch

Minor quibble about the name "CreateVMPressureDispatchOnMainQueue": technically, you're creating a "dispatch source", not a "dispatch". I would have called this "CreateVMPressureDispatchSourceOnMainQueue".
Comment 3 Michael Saboff 2011-10-24 13:56:57 PDT 
Committed r98280: <http://trac.webkit.org/changeset/98280>