Bug 70736 - Web Inspector: print expired message count before remaining messages.
Summary: Web Inspector: print expired message count before remaining messages.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-24 09:55 PDT by Pavel Feldman
Modified: 2011-10-25 01:23 PDT (History)
12 users (show)

See Also:

Attachments
Patch (10.17 KB, patch)
2011-10-24 09:57 PDT, Pavel Feldman 		yurys: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-10-24 09:55:15 PDT 
Patch to follow.
Comment 1 Pavel Feldman 2011-10-24 09:57:08 PDT 
Created attachment 112205 [details]
Patch
Comment 2 WebKit Review Bot 2011-10-24 10:36:35 PDT 
Comment on attachment 112205 [details]
Patch

Attachment 112205 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10205587

New failing tests:
inspector/protocol/console-agent.html
Comment 3 Yury Semikhatsky 2011-10-24 10:48:12 PDT 
Comment on attachment 112205 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112205&action=review

> Source/WebCore/inspector/Inspector-0.1.json:387
> +                    { "name": "expiredMessagesCount", "type": "integer",  "optional": true, "description": "Number of messages dropped due to message threashold overflow." }

One extra space after comma in ',  "optional"'
Comment 4 Pavel Feldman 2011-10-25 01:23:33 PDT 
Committed r98326: <http://trac.webkit.org/changeset/98326>