Bug 70728 - [EFL] Add function to get geometry of focused element
Summary: [EFL] Add function to get geometry of focused element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-24 08:51 PDT by Ivan Briano
Modified: 2011-10-25 12:44 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.19 KB, patch)
2011-10-24 09:23 PDT, Ivan Briano 		no flags Details | Formatted Diff | Diff
Patch (3.29 KB, patch)
2011-10-24 12:46 PDT, Ivan Briano 		no flags Details | Formatted Diff | Diff
Patch (3.30 KB, patch)
2011-10-25 06:22 PDT, Ivan Briano 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Briano 2011-10-24 08:51:06 PDT 
Add function to get geometry of focused element
Comment 1 Ivan Briano 2011-10-24 09:23:46 PDT 
Created attachment 112196 [details]
Patch
Comment 2 Leandro Pereira 2011-10-24 12:38:00 PDT 
Comment on attachment 112196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112196&action=review

LGTM.

> Source/WebKit/efl/ewk/ewk_frame.h:704
> + * Get the grometry, relative to the frame, of the focused element in the

Please fix this typo before landing.
Comment 3 Ivan Briano 2011-10-24 12:46:28 PDT 
Created attachment 112234 [details]
Patch
Comment 4 Grzegorz Czajkowski 2011-10-24 23:36:19 PDT 
View in context: https://bugs.webkit.org/attachment.cgi?id=112234&action=review

> Source/WebKit/efl/ewk/ewk_frame.h:704
> + * Get the geometry, relative to the frame, of the focused element in the

Please use "Gets".

> Source/WebKit/efl/ewk/ewk_frame.h:708
> + * @param x pointer where to store the X value of the geometry. may be @c 0

Could you replace dot to comma here? there is no end of sentence. And please change below three lines too.
Comment 5 Ivan Briano 2011-10-25 06:22:25 PDT 
Created attachment 112328 [details]
Patch
Comment 6 Ivan Briano 2011-10-25 06:23:39 PDT 
Patch updated based on comments and rebased.
Comment 7 Grzegorz Czajkowski 2011-10-25 06:36:00 PDT 
LGTM
Comment 8 WebKit Review Bot 2011-10-25 12:44:34 PDT 
Comment on attachment 112328 [details]
Patch

Clearing flags on attachment: 112328

Committed r98378: <http://trac.webkit.org/changeset/98378>
Comment 9 WebKit Review Bot 2011-10-25 12:44:39 PDT 
All reviewed patches have been landed.  Closing bug.