Bug 70726 - Web Inspector: fix empty line handling in source maps.
Summary: Web Inspector: fix empty line handling in source maps.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-24 08:07 PDT by Pavel Podivilov
Modified: 2011-10-25 07:26 PDT (History)
10 users (show)

See Also:

Attachments
Patch (4.56 KB, patch)
2011-10-24 08:08 PDT, Pavel Podivilov 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-10-24 08:07:31 PDT 
Web Inspector: fix empty line handling in source maps.
Comment 1 Pavel Podivilov 2011-10-24 08:08:59 PDT 
Created attachment 112186 [details]
Patch
Comment 2 Yury Semikhatsky 2011-10-25 06:47:57 PDT 
Comment on attachment 112186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112186&action=review

> Source/WebCore/inspector/front-end/CompilerSourceMapping.js:161
> +                    stringCharIterator.next();

I think you need to check hasNext() here and probably at line 156.

> LayoutTests/inspector/debugger/compiler-source-mapping.html:81
> +                "mappings":"AAAA;;;CACA",

Add test for comma?
Comment 3 Pavel Podivilov 2011-10-25 07:26:15 PDT 
Committed r98345: <http://trac.webkit.org/changeset/98345>