WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
70723
Web Inspector: allow debugging dedicated worker initialization
https://bugs.webkit.org/show_bug.cgi?id=70723
Summary
Web Inspector: allow debugging dedicated worker initialization
Yury Semikhatsky
Reported
2011-10-24 06:29:13 PDT
There should be a way to debug dedicated worker script from the very first statement.
Attachments
Patch
(20.81 KB, patch)
2011-10-24 06:36 PDT
,
Yury Semikhatsky
pfeldman
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
Patch for landing
(19.62 KB, patch)
2011-10-24 07:17 PDT
,
Yury Semikhatsky
no flags
Details
Formatted Diff
Diff
Patch for landing
(21.72 KB, patch)
2011-10-24 07:26 PDT
,
Yury Semikhatsky
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1
2011-10-24 06:36:33 PDT
Created
attachment 112178
[details]
Patch
Pavel Feldman
Comment 2
2011-10-24 06:54:52 PDT
Comment on
attachment 112178
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=112178&action=review
> Source/WebCore/inspector/Inspector.json:385 > + "name": "resume",
run ?
Pavel Feldman
Comment 3
2011-10-24 06:56:36 PDT
Comment on
attachment 112178
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=112178&action=review
> Source/WebCore/inspector/front-end/WorkerManager.js:67 > + WebInspector.WorkerManager._calculateWorkerInspectorTitle();
But why? Could you make this call upon return from some backend method?
WebKit Review Bot
Comment 4
2011-10-24 07:17:05 PDT
Comment on
attachment 112178
[details]
Patch
Attachment 112178
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/10197862
New failing tests: inspector/protocol/runtime-agent.html
Yury Semikhatsky
Comment 5
2011-10-24 07:17:19 PDT
Created
attachment 112182
[details]
Patch for landing
Yury Semikhatsky
Comment 6
2011-10-24 07:17:50 PDT
(In reply to
comment #2
)
> (From update of
attachment 112178
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=112178&action=review
> > > Source/WebCore/inspector/Inspector.json:385 > > + "name": "resume", > > run ?
Done. (In reply to
comment #3
)
> (From update of
attachment 112178
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=112178&action=review
> > > Source/WebCore/inspector/front-end/WorkerManager.js:67 > > + WebInspector.WorkerManager._calculateWorkerInspectorTitle(); > > But why? Could you make this call upon return from some backend method?
Done.
Yury Semikhatsky
Comment 7
2011-10-24 07:26:25 PDT
Created
attachment 112183
[details]
Patch for landing
Yury Semikhatsky
Comment 8
2011-10-24 07:32:10 PDT
Committed
r98237
: <
http://trac.webkit.org/changeset/98237
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug