Bug 70723 - Web Inspector: allow debugging dedicated worker initialization
Summary: Web Inspector: allow debugging dedicated worker initialization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-24 06:29 PDT by Yury Semikhatsky
Modified: 2011-10-24 07:32 PDT (History)
12 users (show)

See Also:

Attachments
Patch (20.81 KB, patch)
2011-10-24 06:36 PDT, Yury Semikhatsky 		pfeldman: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (19.62 KB, patch)
2011-10-24 07:17 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch for landing (21.72 KB, patch)
2011-10-24 07:26 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2011-10-24 06:29:13 PDT 
There should be a way to debug dedicated worker script from the very first statement.
Comment 1 Yury Semikhatsky 2011-10-24 06:36:33 PDT 
Created attachment 112178 [details]
Patch
Comment 2 Pavel Feldman 2011-10-24 06:54:52 PDT 
Comment on attachment 112178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112178&action=review

> Source/WebCore/inspector/Inspector.json:385
> +                "name": "resume",

run ?
Comment 3 Pavel Feldman 2011-10-24 06:56:36 PDT 
Comment on attachment 112178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112178&action=review

> Source/WebCore/inspector/front-end/WorkerManager.js:67
> +            WebInspector.WorkerManager._calculateWorkerInspectorTitle();

But why? Could you make this call upon return from some backend method?
Comment 4 WebKit Review Bot 2011-10-24 07:17:05 PDT 
Comment on attachment 112178 [details]
Patch

Attachment 112178 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10197862

New failing tests:
inspector/protocol/runtime-agent.html
Comment 5 Yury Semikhatsky 2011-10-24 07:17:19 PDT 
Created attachment 112182 [details]
Patch for landing
Comment 6 Yury Semikhatsky 2011-10-24 07:17:50 PDT 
(In reply to comment #2)
> (From update of attachment 112178 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=112178&action=review
> 
> > Source/WebCore/inspector/Inspector.json:385
> > +                "name": "resume",
> 
> run ?

Done.


(In reply to comment #3)
> (From update of attachment 112178 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=112178&action=review
> 
> > Source/WebCore/inspector/front-end/WorkerManager.js:67
> > +            WebInspector.WorkerManager._calculateWorkerInspectorTitle();
> 
> But why? Could you make this call upon return from some backend method?

Done.
Comment 7 Yury Semikhatsky 2011-10-24 07:26:25 PDT 
Created attachment 112183 [details]
Patch for landing
Comment 8 Yury Semikhatsky 2011-10-24 07:32:10 PDT 
Committed r98237: <http://trac.webkit.org/changeset/98237>