Bug 70720 - [GTK] fast/events/event-creation.html fails creating MediaStreamEvent
Summary: [GTK] fast/events/event-creation.html fails creating MediaStreamEvent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-24 05:35 PDT by Alejandro G. Castro
Modified: 2011-11-16 02:35 PST (History)
7 users (show)

See Also:

Attachments
patch (4.01 KB, patch)
2011-11-11 09:03 PST, Per-Erik Brodin 		no flags Details | Formatted Diff | Diff
patch with proper ChangeLog (4.16 KB, patch)
2011-11-12 10:56 PST, Per-Erik Brodin 		no flags Details | Formatted Diff | Diff
patch 3 (4.16 KB, patch)
2011-11-12 14:25 PST, Per-Erik Brodin 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2011-10-24 05:35:39 PDT 
It is happening since http://trac.webkit.org/changeset/98196. I'm going to skip the test until we find the issue, adding people in the commit.
Comment 1 Alejandro G. Castro 2011-10-24 05:56:53 PDT 
Skipped http://trac.webkit.org/changeset/98235
Comment 2 Per-Erik Brodin 2011-11-11 09:03:17 PST 
Created attachment 114711 [details]
patch

MediaStreamEvent changed in r98044 but got accidentally reverted in r98196.
Comment 3 Philippe Normand 2011-11-11 09:26:56 PST 
Comment on attachment 114711 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114711&action=review

Looks good but I'd like to wait a green cr-linux EWS before setting r+

> Source/WebCore/ChangeLog:12
> +        * mediastream/MediaStreamEvent.cpp:
> +        (WebCore::MediaStreamEvent::stream):
> +        (WebCore::MediaStreamEvent::interfaceName):
> +        * mediastream/MediaStreamEvent.h:
> +        * mediastream/MediaStreamEvent.idl:

Can you please explain the changes? At least a general note would be nice.
Comment 4 Per-Erik Brodin 2011-11-12 10:56:02 PST 
Created attachment 114839 [details]
patch with proper ChangeLog

(In reply to comment #3)
> Can you please explain the changes? At least a general note would be nice.

I've updated the ChangeLog.
Comment 5 Per-Erik Brodin 2011-11-12 14:25:18 PST 
Created attachment 114843 [details]
patch 3

Fixed typo.
Comment 6 Philippe Normand 2011-11-13 23:42:24 PST 
Comment on attachment 114843 [details]
patch 3

Thanks!
Comment 7 WebKit Review Bot 2011-11-16 02:35:46 PST 
Comment on attachment 114843 [details]
patch 3

Clearing flags on attachment: 114843

Committed r100425: <http://trac.webkit.org/changeset/100425>
Comment 8 WebKit Review Bot 2011-11-16 02:35:53 PST 
All reviewed patches have been landed.  Closing bug.