Bug 70711 - [EFL] Fix occurrence of unpainted tile while scrolling by using ewk_tiled_view.
Summary: [EFL] Fix occurrence of unpainted tile while scrolling by using ewk_tiled_view.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-24 00:57 PDT by KwangHyuk
Modified: 2011-10-25 19:10 PDT (History)
8 users (show)

See Also:

Attachments
Patch. (2.43 KB, patch)
2011-10-24 04:38 PDT, KwangHyuk 		no flags Details | Formatted Diff | Diff
patch. (2.87 KB, patch)
2011-10-25 17:28 PDT, KwangHyuk 		abarth: review+
abarth: commit-queue+
Details | Formatted Diff | Diff
Patch. (2.87 KB, patch)
2011-10-25 17:36 PDT, KwangHyuk 		abarth: review+
abarth: commit-queue+
Details | Formatted Diff | Diff
patch. (2.87 KB, patch)
2011-10-25 17:41 PDT, KwangHyuk 		hyuki.kim: review+
Details | Formatted Diff | Diff
patch. (2.87 KB, patch)
2011-10-25 17:43 PDT, KwangHyuk 		no flags Details | Formatted Diff | Diff
Patch. (2.87 KB, patch)
2011-10-25 18:06 PDT, KwangHyuk 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description KwangHyuk 2011-10-24 00:57:08 PDT 
The number of visible tiles on viewport does not seem to be calculated properly because of calculation fault.
As a result, unpainted area sometimes appears in viewport when ewk_view is an instance of tiled view.
Comment 1 KwangHyuk 2011-10-24 04:38:22 PDT 
Created attachment 112175 [details]
Patch.
Comment 2 KwangHyuk 2011-10-24 18:21:16 PDT 
To get a floating point number, any op
Comment 3 KwangHyuk 2011-10-24 18:48:28 PDT 
at least one of operatee should be a float number.
Comment 4 Raphael Kubo da Costa (:rakuco) 2011-10-24 19:58:39 PDT 
Comment on attachment 112175 [details]
Patch.

LGTM, but the ChangeLog message looks confusing (your comments in the bug report help explain the fix, but it is still not clear to me what effects this bug was causing).
Comment 5 KwangHyuk 2011-10-24 21:19:53 PDT 
> LGTM, but the ChangeLog message looks confusing (your comments in the bug report help explain the fix, but it is still not clear to me what effects this bug was causing).

Ok, Thank you for your comment. :-)
I will add more detail description for the patch.
Comment 6 KwangHyuk 2011-10-25 17:28:14 PDT 
Created attachment 112430 [details]
patch.
Comment 7 Adam Barth 2011-10-25 17:34:40 PDT 
Comment on attachment 112430 [details]
patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=112430&action=review

> Source/WebKit/efl/ChangeLog:8
> +        Cast one of operatess to float type when ewk_tiled_backing_store calculate tiles list on viewport.

operatess ?
Comment 8 KwangHyuk 2011-10-25 17:36:46 PDT 
Created attachment 112432 [details]
Patch.
Comment 9 KwangHyuk 2011-10-25 17:41:50 PDT 
Created attachment 112433 [details]
patch.
Comment 10 KwangHyuk 2011-10-25 17:43:19 PDT 
Created attachment 112434 [details]
patch.
Comment 11 KwangHyuk 2011-10-25 18:06:24 PDT 
Created attachment 112437 [details]
Patch.
Comment 12 WebKit Review Bot 2011-10-25 19:10:41 PDT 
Comment on attachment 112437 [details]
Patch.

Clearing flags on attachment: 112437

Committed r98424: <http://trac.webkit.org/changeset/98424>
Comment 13 WebKit Review Bot 2011-10-25 19:10:46 PDT 
All reviewed patches have been landed.  Closing bug.