Bug 70694 - Web Inspector: Make CSS files load upon View demand; split inspector.css into views.
Summary: Web Inspector: Make CSS files load upon View demand; split inspector.css into...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-23 07:34 PDT by Pavel Feldman
Modified: 2011-10-24 06:21 PDT (History)
12 users (show)

See Also:

Attachments
Patch (205.75 KB, patch)
2011-10-23 07:36 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
[Patch] Split into 3, part 3. (155.58 KB, patch)
2011-10-23 08:51 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
[Patch] patch for landing (155.60 KB, patch)
2011-10-24 02:57 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-10-23 07:34:37 PDT 
Patch to follow.
Comment 1 Pavel Feldman 2011-10-23 07:36:45 PDT 
Created attachment 112111 [details]
Patch
Comment 2 Pavel Feldman 2011-10-23 07:38:57 PDT 
I will split it into three patches for landing:

1) Make View lazy load CSS files
2) Convert DataGrid to View
3) Split CSS into multiple files

But these are absolutely orthogonal, should not be uncomfortable to review. While only taken together I could test the functionality working properly.
Comment 3 WebKit Review Bot 2011-10-23 07:40:14 PDT 
Comment on attachment 112111 [details]
Patch

Attachment 112111 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10205185
Comment 4 Early Warning System Bot 2011-10-23 07:43:28 PDT 
Comment on attachment 112111 [details]
Patch

Attachment 112111 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10199466
Comment 5 Pavel Feldman 2011-10-23 08:51:48 PDT 
Created attachment 112114 [details]
[Patch] Split into 3, part 3.
Comment 6 Pavel Feldman 2011-10-24 02:57:37 PDT 
Created attachment 112168 [details]
[Patch] patch for landing
Comment 7 Pavel Feldman 2011-10-24 03:00:54 PDT 
Committed r98228: <http://trac.webkit.org/changeset/98228>