Bug 70693 - [Qt][WK2] QDesktopWebView and QTouchWebView should be declared in the meta type system.
Summary: [Qt][WK2] QDesktopWebView and QTouchWebView should be declared in the meta ty...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zeno Albisser
URL:
Keywords:
Depends on:
Blocks: 70315
  Show dependency tree / graph
 
Reported: 2011-10-23 05:58 PDT by Zeno Albisser
Modified: 2011-10-25 06:37 PDT (History)
1 user (show)

See Also:

Attachments
patch for review. (1.57 KB, patch)
2011-10-23 06:05 PDT, Zeno Albisser 		vestbo: review-
Details | Formatted Diff | Diff
patch for review. (1.60 KB, patch)
2011-10-23 13:51 PDT, Zeno Albisser 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Albisser 2011-10-23 05:58:19 PDT 
Without that we cannot use these types in the template based functions of the meta type system. (QVariant)

If we instantiate a QDesktopWebView or a QTouchWebView in QML but want to acess it also in C++, then we need to ask the meta type system in c++ for the type of the object.
Comment 1 Zeno Albisser 2011-10-23 06:05:22 PDT 
Created attachment 112109 [details]
patch for review.

is there a good reason why we should not do that?
Comment 2 Tor Arne Vestbø 2011-10-23 12:49:16 PDT 
Comment on attachment 112109 [details]
patch for review.

Yepp, this is the place we should do it. But it should be QML_DECLARE_TYPE(QTouchWebView), to get the pointer automatically and cover the list-usecase.

http://doc.qt.nokia.com/4.7-snapshot/qdeclarativeengine.html#QML_DECLARE_TYPE
Comment 3 Zeno Albisser 2011-10-23 13:51:01 PDT 
Created attachment 112125 [details]
patch for review.
Comment 4 Simon Hausmann 2011-10-25 05:31:08 PDT 
Comment on attachment 112125 [details]
patch for review.

r=me
Comment 5 WebKit Review Bot 2011-10-25 06:37:36 PDT 
Comment on attachment 112125 [details]
patch for review.

Clearing flags on attachment: 112125

Committed r98337: <http://trac.webkit.org/changeset/98337>
Comment 6 WebKit Review Bot 2011-10-25 06:37:39 PDT 
All reviewed patches have been landed.  Closing bug.