Bug 70674 - [WK2][GTK] Missing env variables cause WKTR to crash
Summary: [WK2][GTK] Missing env variables cause WKTR to crash
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 69523
  Show dependency treegraph
Reported: 2011-10-22 03:03 PDT by Zan Dobersek
Modified: 2011-10-22 09:37 PDT (History)
3 users (show)

See Also:

Patch (2.03 KB, patch)
2011-10-22 03:46 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2011-10-22 03:03:33 PDT
Currently WebKitTestRunner will crash when running tests if TEST_RUNNER_INJECTED_BUNDLE_FILENAME and TEST_RUNNER_TEST_PLUGIN_PATH env variables are not set. While this can be avoided by manually exporting these it should really be done by the new-run-webkit-tests script.

Patch on the way.
Comment 1 Zan Dobersek 2011-10-22 03:46:57 PDT
Created attachment 112083 [details]

This patch sets the necessary variables and also fixes one inappropriate use of _build_path function.
Comment 2 WebKit Review Bot 2011-10-22 09:37:34 PDT
Comment on attachment 112083 [details]

Clearing flags on attachment: 112083

Committed r98193: <http://trac.webkit.org/changeset/98193>
Comment 3 WebKit Review Bot 2011-10-22 09:37:39 PDT
All reviewed patches have been landed.  Closing bug.