Corresponding bug for chromium: https://bugs.webkit.org/show_bug.cgi?id=70580
Created attachment 112296 [details] Fix + tests
Comment on attachment 112296 [details] Fix + tests View in context: https://bugs.webkit.org/attachment.cgi?id=112296&action=review Looks good to me (with a few minor nits). (I don't know about the cast static_cast<JSDOMGlobalObject*>(m_exec->lexicalGlobalObject())). Hopefully Oliver will weigh in on it too! > Source/WebCore/bindings/js/SerializedScriptValue.cpp:290 > + extra blank line. > Source/WebCore/bindings/js/SerializedScriptValue.cpp:1212 > + if (!m_messagePorts || index >= m_messagePorts->size()) { Why not just combine this with the previous if ||...
(In reply to comment #2) > (From update of attachment 112296 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=112296&action=review > > Looks good to me (with a few minor nits). (I don't know about the cast static_cast<JSDOMGlobalObject*>(m_exec->lexicalGlobalObject())). From what I see, the assumption of this cast holds, but an opinion of an experienced JSC engineer is most welcome.
Created attachment 112364 [details] CR comments addressed (thanks David!)
Comment on attachment 112364 [details] CR comments addressed (thanks David!) Looks good. Thanks!
Comment on attachment 112364 [details] CR comments addressed (thanks David!) Clearing flags on attachment: 112364 Committed r98879: <http://trac.webkit.org/changeset/98879>
All reviewed patches have been landed. Closing bug.