Bug 70654 – Rename WKProcessCluster to WKProcessGroup

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Rename WKProcessCluster to WKProcessGroup

[Sam Weinig]

Created attachment 112030 [details]
Patch

[WebKit Review Bot]

Attachment 112030 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/API/mac/WKProcessGroup.h:33:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebKit2/UIProcess/API/mac/WKProcessGroupInternal.h:28:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 112030 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112030&action=review

> Source/WebKit2/UIProcess/API/mac/WKProcessGroup.h:37
> +- (id)init;

You don't need to declare -init in the header.

> Source/WebKit2/UIProcess/API/mac/WKProcessGroup.mm:56
> +    _data = [[WKProcessClusterData alloc] init];

Can't we use 'retain' properties for this?

[Sam Weinig]

(In reply to comment #3)
> (From update of attachment 112030 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=112030&action=review
> 
> > Source/WebKit2/UIProcess/API/mac/WKProcessGroup.h:37
> > +- (id)init;
> 
> You don't need to declare -init in the header.

Will remove.

> > Source/WebKit2/UIProcess/API/mac/WKProcessGroup.mm:56
> > +    _data = [[WKProcessClusterData alloc] init];
> 
> Can't we use 'retain' properties for this?

Since _data is meant to be @private (will fix this too), I don't think I can use an @property.  Once we don't compile the API in the fragile Objective-C ABI, I can use a class extension with a @property though.

[Sam Weinig]

Committed r98160: <http://trac.webkit.org/changeset/98160>