RESOLVED FIXED 70653
Remove ability to create a WKView without a WKContextRef and WKPageGroupRef 
https://bugs.webkit.org/show_bug.cgi?id=70653
Summary Remove ability to create a WKView without a WKContextRef and WKPageGroupRef
Sam Weinig
Reported 2011-10-21 14:59:26 PDT
Remove ability to create a WKView without a WKContextRef and WKPageGroupRef
Attachments
Patch (9.16 KB, patch)
2011-10-21 15:02 PDT, Sam Weinig 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-10-21 15:02:51 PDT
Created attachment 112026 [details] Patch
Simon Fraser (smfr)
Comment 2 2011-10-21 15:04:14 PDT
Comment on attachment 112026 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112026&action=review > Source/WebKit2/ChangeLog:4 > + Remove ability to create a WKView without a WKContextRef and WKPageGroupRef > + https://bugs.webkit.org/show_bug.cgi?id=70653 Why?
Sam Weinig
Comment 3 2011-10-21 15:05:28 PDT
It is just to simplify things, removing the need for shared contexts.
Darin Adler
Comment 4 2011-10-21 15:05:38 PDT
Comment on attachment 112026 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112026&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:-204 > -- (id)initWithFrame:(NSRect)frame > -{ > - return [self initWithFrame:frame contextRef:toAPI(WebContext::sharedProcessContext())]; > -} This is the designated initializer of the superclass. Normally you have to override this, at least to return nil.
Sam Weinig
Comment 5 2011-10-21 15:08:20 PDT
Committed r98159: <http://trac.webkit.org/changeset/98159>
Sam Weinig
Comment 6 2011-10-21 15:09:32 PDT
It is just to simplify things, removing the need for shared contexts.(In reply to comment #4) > (From update of attachment 112026 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=112026&action=review > > > Source/WebKit2/UIProcess/API/mac/WKView.mm:-204 > > -- (id)initWithFrame:(NSRect)frame > > -{ > > - return [self initWithFrame:frame contextRef:toAPI(WebContext::sharedProcessContext())]; > > -} > > This is the designated initializer of the superclass. Normally you have to override this, at least to return nil. Good point. Is it more idiomatic to return nil or throw (or both)?
Note You need to log in before you can comment on or make changes to this bug.