Bug 70653 - Remove ability to create a WKView without a WKContextRef and WKPageGroupRef
Summary: Remove ability to create a WKView without a WKContextRef and WKPageGroupRef
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-21 14:59 PDT by Sam Weinig
Modified: 2011-10-21 15:09 PDT (History)
0 users

See Also:

Attachments
Patch (9.16 KB, patch)
2011-10-21 15:02 PDT, Sam Weinig 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-10-21 14:59:26 PDT 
Remove ability to create a WKView without a WKContextRef and WKPageGroupRef
Comment 1 Sam Weinig 2011-10-21 15:02:51 PDT 
Created attachment 112026 [details]
Patch
Comment 2 Simon Fraser (smfr) 2011-10-21 15:04:14 PDT 
Comment on attachment 112026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112026&action=review

> Source/WebKit2/ChangeLog:4
> +        Remove ability to create a WKView without a WKContextRef and WKPageGroupRef
> +        https://bugs.webkit.org/show_bug.cgi?id=70653

Why?
Comment 3 Sam Weinig 2011-10-21 15:05:28 PDT 
It is just to simplify things, removing the need for shared contexts.
Comment 4 Darin Adler 2011-10-21 15:05:38 PDT 
Comment on attachment 112026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112026&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:-204
> -- (id)initWithFrame:(NSRect)frame
> -{
> -    return [self initWithFrame:frame contextRef:toAPI(WebContext::sharedProcessContext())];
> -}

This is the designated initializer of the superclass. Normally you have to override this, at least to return nil.
Comment 5 Sam Weinig 2011-10-21 15:08:20 PDT 
Committed r98159: <http://trac.webkit.org/changeset/98159>
Comment 6 Sam Weinig 2011-10-21 15:09:32 PDT 
It is just to simplify things, removing the need for shared contexts.(In reply to comment #4)
> (From update of attachment 112026 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=112026&action=review
> 
> > Source/WebKit2/UIProcess/API/mac/WKView.mm:-204
> > -- (id)initWithFrame:(NSRect)frame
> > -{
> > -    return [self initWithFrame:frame contextRef:toAPI(WebContext::sharedProcessContext())];
> > -}
> 
> This is the designated initializer of the superclass. Normally you have to override this, at least to return nil.

Good point. Is it more idiomatic to return nil or throw (or both)?