Bug 70651 - [Qt] Remote debugging needs QWebInspector to work
Summary: [Qt] Remote debugging needs QWebInspector to work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Luiz Agostini
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-10-21 14:32 PDT by Luiz Agostini
Modified: 2011-10-21 15:32 PDT (History)
1 user (show)

See Also:

Attachments
patch (9.72 KB, patch)
2011-10-21 14:46 PDT, Luiz Agostini 		kenneth: review+
Details | Formatted Diff | Diff
patch (9.71 KB, patch)
2011-10-21 15:17 PDT, Luiz Agostini 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luiz Agostini 2011-10-21 14:32:33 PDT 
Remote debugger causes a crash if the page does not have a QWebInspector associated to it.
QWebInspector is a QWidget object that should not be needed by the remote inspector.
Comment 1 Luiz Agostini 2011-10-21 14:46:44 PDT 
Created attachment 112024 [details]
patch
Comment 2 Kenneth Rohde Christiansen 2011-10-21 14:52:46 PDT 
Comment on attachment 112024 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112024&action=review

> Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:287
> +        WTF::CString qwe = message.utf8();

Can you find a better name than qwe.... I have no idea what that stands for
Comment 3 Luiz Agostini 2011-10-21 14:55:16 PDT 
(In reply to comment #2)
> (From update of attachment 112024 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=112024&action=review
> 
> > Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:287
> > +        WTF::CString qwe = message.utf8();
> 
> Can you find a better name than qwe.... I have no idea what that stands for

absolutely! :)

Sorry for that.
Comment 4 Luiz Agostini 2011-10-21 15:17:28 PDT 
Created attachment 112031 [details]
patch
Comment 5 WebKit Review Bot 2011-10-21 15:32:42 PDT 
Comment on attachment 112031 [details]
patch

Clearing flags on attachment: 112031

Committed r98162: <http://trac.webkit.org/changeset/98162>
Comment 6 WebKit Review Bot 2011-10-21 15:32:46 PDT 
All reviewed patches have been landed.  Closing bug.