Bug 70639 - [Qt] Wrong type conversion in InspectorServerQt.cpp
Summary: [Qt] Wrong type conversion in InspectorServerQt.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Luiz Agostini
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-10-21 13:33 PDT by Luiz Agostini
Modified: 2011-10-21 15:01 PDT (History)
1 user (show)

See Also:

Attachments
patch (1.96 KB, patch)
2011-10-21 13:59 PDT, Luiz Agostini 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luiz Agostini 2011-10-21 13:33:14 PDT 
The WebSocket keys are been converted from string to long instead of unsigned long. This is causing WebSocket handshake failures for the remote inspector.
Comment 1 Luiz Agostini 2011-10-21 13:59:42 PDT 
Created attachment 112017 [details]
patch
Comment 2 Noam Rosenthal 2011-10-21 14:02:04 PDT 
Comment on attachment 112017 [details]
patch

LGTM
Comment 3 WebKit Review Bot 2011-10-21 15:01:00 PDT 
Comment on attachment 112017 [details]
patch

Clearing flags on attachment: 112017

Committed r98158: <http://trac.webkit.org/changeset/98158>
Comment 4 WebKit Review Bot 2011-10-21 15:01:05 PDT 
All reviewed patches have been landed.  Closing bug.