Bug 70638 - Remove getConstructDataVirtual
Summary: Remove getConstructDataVirtual
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks: 67690
  Show dependency tree / graph
 
Reported: 2011-10-21 13:20 PDT by Mark Hahnenberg
Modified: 2011-10-23 15:53 PDT (History)
3 users (show)

See Also:

Attachments
Patch (43.64 KB, patch)
2011-10-21 13:22 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (44.74 KB, patch)
2011-10-21 18:22 PDT, Mark Hahnenberg 		darin: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2011-10-21 13:20:10 PDT 
Now that we have an entry in the MethodTable for getConstructData, we can remove its virtual counterpart and replace all call sites with an explicit lookup in the MethodTable.
Comment 1 Mark Hahnenberg 2011-10-21 13:22:14 PDT 
Created attachment 112008 [details]
Patch
Comment 2 Mark Hahnenberg 2011-10-21 18:22:10 PDT 
Created attachment 112054 [details]
Patch
Comment 3 WebKit Review Bot 2011-10-23 14:14:57 PDT 
Comment on attachment 112054 [details]
Patch

Rejecting attachment 112054 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
s/Plugins/Netscape/JSNPObject.cpp
Hunk #1 FAILED at 236.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.cpp.rej
patching file Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.h
Hunk #1 FAILED at 80.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/10203571
Comment 4 Mark Hahnenberg 2011-10-23 15:53:07 PDT 
Committed r98203: <http://trac.webkit.org/changeset/98203>